From: Yinghai Lu <yinghai@kernel.org>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Jeff Garrett <jeff@jgarrett.org>,
linux-kernel@vger.kernel.org, Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org,
Jesse Barnes <jbarnes@virtuousgeek.org>,
linux-pci@vger.kernel.org, David Airlie <airlied@linux.ie>
Subject: [PATCH] x86/pci: intel ioh need to subtract mmconf range
Date: Thu, 14 Jan 2010 14:46:35 -0800 [thread overview]
Message-ID: <4B4F9ECB.4060805@kernel.org> (raw)
In-Reply-To: <201001141108.03129.bjorn.helgaas@hp.com>
Bjorn pointed out we need to remove mmconf range
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
---
arch/x86/pci/intel_bus.c | 29 +++++++++++++++++++++++++++--
1 file changed, 27 insertions(+), 2 deletions(-)
Index: linux-2.6/arch/x86/pci/intel_bus.c
===================================================================
--- linux-2.6.orig/arch/x86/pci/intel_bus.c
+++ linux-2.6/arch/x86/pci/intel_bus.c
@@ -46,6 +46,20 @@ static inline void print_ioh_resources(s
#define RANGE_NUM 16
+static void __devinit subtract_mmconf(struct range *range, int nr)
+{
+#ifdef CONFIG_PCI_MMCONFIG
+ struct pci_mmcfg_region *cfg;
+
+ if (list_empty(&pci_mmcfg_list))
+ return;
+
+ list_for_each_entry(cfg, &pci_mmcfg_list, list)
+ subtract_range(range, nr, cfg->res.start,
+ cfg->res.end + 1);
+#endif
+}
+
static void __devinit pci_root_bus_res(struct pci_dev *dev)
{
u16 word;
@@ -96,6 +110,7 @@ static void __devinit pci_root_bus_res(s
subtract_range(range, RANGE_NUM, vt_base, vt_end + 1);
}
+ subtract_mmconf(range, RANGE_NUM);
for (i = 0; i < RANGE_NUM; i++) {
if (!range[i].end)
continue;
@@ -112,8 +127,18 @@ static void __devinit pci_root_bus_res(s
mmioh_base |= ((u64)(dword & 0x7ffff)) << 32;
pci_read_config_dword(dev, IOH_LMMIOH_LIMITU, &dword);
mmioh_end |= ((u64)(dword & 0x7ffff)) << 32;
- update_res(info, cap_resource(mmioh_base), cap_resource(mmioh_end),
- IORESOURCE_MEM, 0);
+ memset(range, 0, sizeof(range));
+ add_range(range, RANGE_NUM, 0, mmioh_base, mmioh_end + 1);
+ /* mmconf could be above 4g */
+ subtract_mmconf(range, RANGE_NUM);
+ for (i = 0; i < RANGE_NUM; i++) {
+ if (!range[i].end)
+ continue;
+
+ update_res(info, cap_resource(range[i].start),
+ cap_resource(range[i].end - 1),
+ IORESOURCE_MEM, 0);
+ }
print_ioh_resources(info);
}
next prev parent reply other threads:[~2010-01-14 22:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-13 5:37 2.6.33-rc3: pci host bridge windows ignored (works with pci=use_crs) Jeff Garrett
2010-01-13 8:44 ` Yinghai Lu
2010-01-13 8:45 ` Yinghai Lu
2010-01-13 13:24 ` Jeff Garrett
2010-01-14 7:46 ` Yinghai Lu
2010-01-14 18:08 ` Bjorn Helgaas
2010-01-14 22:46 ` Yinghai Lu [this message]
2010-01-14 23:09 ` [PATCH] x86/pci: intel ioh need to subtract mmconf range Bjorn Helgaas
2010-01-14 23:38 ` Yinghai Lu
2010-01-14 23:49 ` Bjorn Helgaas
2010-01-15 0:39 ` Yinghai Lu
2010-01-15 18:14 ` Jesse Barnes
2010-01-19 19:42 ` Jeff Garrett
2010-01-19 19:57 ` Yinghai Lu
2010-01-19 22:52 ` Bjorn Helgaas
2010-01-19 22:54 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4F9ECB.4060805@kernel.org \
--to=yinghai@kernel.org \
--cc=airlied@linux.ie \
--cc=bjorn.helgaas@hp.com \
--cc=jbarnes@virtuousgeek.org \
--cc=jeff@jgarrett.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox