* [PATCH] ACPICA: wrong acpi_parse_state assigned acpi_ps_init_scope() ?
@ 2010-01-15 0:31 Roel Kluin
2010-01-15 1:47 ` Lin Ming
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2010-01-15 0:31 UTC (permalink / raw)
To: Len Brown, linux-acpi, Andrew Morton, LKML
Assign the package end, not the last AML byte.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
Is this right?
diff --git a/drivers/acpi/acpica/psscope.c b/drivers/acpi/acpica/psscope.c
index 2feca5c..a8dfe16 100644
--- a/drivers/acpi/acpica/psscope.c
+++ b/drivers/acpi/acpica/psscope.c
@@ -118,7 +118,7 @@ acpi_ps_init_scope(struct acpi_parse_state * parser_state,
scope->parse_scope.op = root_op;
scope->parse_scope.arg_count = ACPI_VAR_ARGS;
scope->parse_scope.arg_end = parser_state->aml_end;
- scope->parse_scope.pkg_end = parser_state->aml_end;
+ scope->parse_scope.pkg_end = parser_state->pkg_end;
parser_state->scope = scope;
parser_state->start_op = root_op;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ACPICA: wrong acpi_parse_state assigned acpi_ps_init_scope() ?
2010-01-15 0:31 [PATCH] ACPICA: wrong acpi_parse_state assigned acpi_ps_init_scope() ? Roel Kluin
@ 2010-01-15 1:47 ` Lin Ming
0 siblings, 0 replies; 2+ messages in thread
From: Lin Ming @ 2010-01-15 1:47 UTC (permalink / raw)
To: Roel Kluin; +Cc: Len Brown, linux-acpi, Andrew Morton, LKML
On Fri, Jan 15, 2010 at 8:31 AM, Roel Kluin <roel.kluin@gmail.com> wrote:
> Assign the package end, not the last AML byte.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> Is this right?
>
> diff --git a/drivers/acpi/acpica/psscope.c b/drivers/acpi/acpica/psscope.c
> index 2feca5c..a8dfe16 100644
> --- a/drivers/acpi/acpica/psscope.c
> +++ b/drivers/acpi/acpica/psscope.c
> @@ -118,7 +118,7 @@ acpi_ps_init_scope(struct acpi_parse_state * parser_state,
> scope->parse_scope.op = root_op;
> scope->parse_scope.arg_count = ACPI_VAR_ARGS;
> scope->parse_scope.arg_end = parser_state->aml_end;
> - scope->parse_scope.pkg_end = parser_state->aml_end;
> + scope->parse_scope.pkg_end = parser_state->pkg_end;
->aml_end and ->pkg_end are same here.
acpi_ps_init_scope is only called in acpi_ds_init_aml_walk which set
aml_end and pkg_end the same.
acpi_ds_init_aml_walk(...)
{
....
walk_state->parser_state.aml_end =
walk_state->parser_state.pkg_end = aml_start + aml_length;
.....
status = acpi_ps_init_scope(&walk_state->parser_state, op);
.....
}
Lin Ming
>
> parser_state->scope = scope;
> parser_state->start_op = root_op;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-01-15 1:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-15 0:31 [PATCH] ACPICA: wrong acpi_parse_state assigned acpi_ps_init_scope() ? Roel Kluin
2010-01-15 1:47 ` Lin Ming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox