* [resend][PATCH 1/2] kprobetrace,doc: shell need single quote to use $ character
@ 2010-01-14 2:14 KOSAKI Motohiro
2010-01-14 2:16 ` [resend][PATCH 2/2] kprobetrace, doc: Add the explanation to remove probe points KOSAKI Motohiro
2010-01-14 5:00 ` [resend][PATCH 1/2] kprobetrace,doc: shell need single quote to use $ character Masami Hiramatsu
0 siblings, 2 replies; 14+ messages in thread
From: KOSAKI Motohiro @ 2010-01-14 2:14 UTC (permalink / raw)
To: Masami Hiramatsu, LKML, Ingo Molnar; +Cc: kosaki.motohiro
shell interpret $val is as shell variable. thus we need quote if
we use echo command.
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Acked-by: Masami Hiramatsu <mhiramat@redhat.com>
---
Documentation/trace/kprobetrace.txt | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/trace/kprobetrace.txt b/Documentation/trace/kprobetrace.txt
index 47aabee..2be6e19 100644
--- a/Documentation/trace/kprobetrace.txt
+++ b/Documentation/trace/kprobetrace.txt
@@ -82,13 +82,13 @@ Usage examples
To add a probe as a new event, write a new definition to kprobe_events
as below.
- echo p:myprobe do_sys_open dfd=$arg0 filename=$arg1 flags=$arg2 mode=$arg3 > /sys/kernel/debug/tracing/kprobe_events
+ echo 'p:myprobe do_sys_open dfd=$arg0 filename=$arg1 flags=$arg2 mode=$arg3' > /sys/kernel/debug/tracing/kprobe_events
This sets a kprobe on the top of do_sys_open() function with recording
1st to 4th arguments as "myprobe" event. As this example shows, users can
choose more familiar names for each arguments.
- echo r:myretprobe do_sys_open $retval >> /sys/kernel/debug/tracing/kprobe_events
+ echo 'r:myretprobe do_sys_open $retval' >> /sys/kernel/debug/tracing/kprobe_events
This sets a kretprobe on the return point of do_sys_open() function with
recording return value as "myretprobe" event.
--
1.6.5.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [resend][PATCH 2/2] kprobetrace, doc: Add the explanation to remove probe points
2010-01-14 2:14 [resend][PATCH 1/2] kprobetrace,doc: shell need single quote to use $ character KOSAKI Motohiro
@ 2010-01-14 2:16 ` KOSAKI Motohiro
2010-01-14 5:00 ` [resend][PATCH 1/2] kprobetrace,doc: shell need single quote to use $ character Masami Hiramatsu
1 sibling, 0 replies; 14+ messages in thread
From: KOSAKI Motohiro @ 2010-01-14 2:16 UTC (permalink / raw)
To: Masami Hiramatsu, LKML, Ingo Molnar; +Cc: kosaki.motohiro
Latest kprobetrace can remove probe points selectively. thus
documentation should be updated too.
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Acked-by: Masami Hiramatsu <mhiramat@redhat.com>
---
Documentation/trace/kprobetrace.txt | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/Documentation/trace/kprobetrace.txt b/Documentation/trace/kprobetrace.txt
index 2be6e19..8c88930 100644
--- a/Documentation/trace/kprobetrace.txt
+++ b/Documentation/trace/kprobetrace.txt
@@ -24,6 +24,7 @@ Synopsis of kprobe_events
-------------------------
p[:[GRP/]EVENT] SYMBOL[+offs]|MEMADDR [FETCHARGS] : Set a probe
r[:[GRP/]EVENT] SYMBOL[+0] [FETCHARGS] : Set a return probe
+ -:[GRP/]EVENT : Clear a probe
GRP : Group name. If omitted, use "kprobes" for it.
EVENT : Event name. If omitted, the event name is generated
@@ -121,6 +122,12 @@ print fmt: "(%lx) dfd=%lx filename=%lx flags=%lx mode=%lx", REC->ip, REC->dfd, R
This clears all probe points.
+ Or,
+
+ echo -:myprobe >> kprobe_events
+
+ This clears probe points selectively.
+
Right after definition, each event is disabled by default. For tracing these
events, you need to enable it.
--
1.6.5.2
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [resend][PATCH 1/2] kprobetrace,doc: shell need single quote to use $ character
2010-01-14 2:14 [resend][PATCH 1/2] kprobetrace,doc: shell need single quote to use $ character KOSAKI Motohiro
2010-01-14 2:16 ` [resend][PATCH 2/2] kprobetrace, doc: Add the explanation to remove probe points KOSAKI Motohiro
@ 2010-01-14 5:00 ` Masami Hiramatsu
2010-01-14 5:17 ` KOSAKI Motohiro
1 sibling, 1 reply; 14+ messages in thread
From: Masami Hiramatsu @ 2010-01-14 5:00 UTC (permalink / raw)
To: KOSAKI Motohiro; +Cc: LKML, Ingo Molnar
KOSAKI Motohiro wrote:
> shell interpret $val is as shell variable. thus we need quote if
> we use echo command.
>
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> Acked-by: Masami Hiramatsu <mhiramat@redhat.com>
Hi Ingo and KOSAKI-san,
Sorry, now this patch conflicts with my patch(commit 1464010) on the
latest -tip tree. The patch drops $argN support, so I updated the
1st example command.
Thank you,
> ---
> Documentation/trace/kprobetrace.txt | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/trace/kprobetrace.txt b/Documentation/trace/kprobetrace.txt
> index 47aabee..2be6e19 100644
> --- a/Documentation/trace/kprobetrace.txt
> +++ b/Documentation/trace/kprobetrace.txt
> @@ -82,13 +82,13 @@ Usage examples
> To add a probe as a new event, write a new definition to kprobe_events
> as below.
>
> - echo p:myprobe do_sys_open dfd=$arg0 filename=$arg1 flags=$arg2 mode=$arg3 > /sys/kernel/debug/tracing/kprobe_events
> + echo 'p:myprobe do_sys_open dfd=$arg0 filename=$arg1 flags=$arg2 mode=$arg3' > /sys/kernel/debug/tracing/kprobe_events
>
> This sets a kprobe on the top of do_sys_open() function with recording
> 1st to 4th arguments as "myprobe" event. As this example shows, users can
> choose more familiar names for each arguments.
>
> - echo r:myretprobe do_sys_open $retval >> /sys/kernel/debug/tracing/kprobe_events
> + echo 'r:myretprobe do_sys_open $retval' >> /sys/kernel/debug/tracing/kprobe_events
>
> This sets a kretprobe on the return point of do_sys_open() function with
> recording return value as "myretprobe" event.
--
Masami Hiramatsu
Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division
e-mail: mhiramat@redhat.com
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [resend][PATCH 1/2] kprobetrace,doc: shell need single quote to use $ character
2010-01-14 5:00 ` [resend][PATCH 1/2] kprobetrace,doc: shell need single quote to use $ character Masami Hiramatsu
@ 2010-01-14 5:17 ` KOSAKI Motohiro
2010-01-17 7:14 ` Ingo Molnar
0 siblings, 1 reply; 14+ messages in thread
From: KOSAKI Motohiro @ 2010-01-14 5:17 UTC (permalink / raw)
To: Masami Hiramatsu; +Cc: kosaki.motohiro, LKML, Ingo Molnar
> KOSAKI Motohiro wrote:
> > shell interpret $val is as shell variable. thus we need quote if
> > we use echo command.
> >
> > Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> > Acked-by: Masami Hiramatsu <mhiramat@redhat.com>
>
> Hi Ingo and KOSAKI-san,
>
> Sorry, now this patch conflicts with my patch(commit 1464010) on the
> latest -tip tree. The patch drops $argN support, so I updated the
> 1st example command.
>
> Thank you,
Oh, I'm sorry. I didn't notice that.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [resend][PATCH 1/2] kprobetrace,doc: shell need single quote to use $ character
2010-01-14 5:17 ` KOSAKI Motohiro
@ 2010-01-17 7:14 ` Ingo Molnar
2010-01-19 2:35 ` [PATCH -tip 1/2] kprobetrace, doc: " Masami Hiramatsu
2010-01-19 2:35 ` [PATCH -tip 2/2] kprobetrace, doc: Add the explanation to remove probe points Masami Hiramatsu
0 siblings, 2 replies; 14+ messages in thread
From: Ingo Molnar @ 2010-01-17 7:14 UTC (permalink / raw)
To: KOSAKI Motohiro; +Cc: Masami Hiramatsu, LKML
* KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:
> > KOSAKI Motohiro wrote:
> > > shell interpret $val is as shell variable. thus we need quote if
> > > we use echo command.
> > >
> > > Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> > > Acked-by: Masami Hiramatsu <mhiramat@redhat.com>
> >
> > Hi Ingo and KOSAKI-san,
> >
> > Sorry, now this patch conflicts with my patch(commit 1464010) on the
> > latest -tip tree. The patch drops $argN support, so I updated the
> > 1st example command.
> >
> > Thank you,
>
> Oh, I'm sorry. I didn't notice that.
Mind resending a version with the patch conflicts resolved?
Thanks,
Ingo
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH -tip 1/2] kprobetrace, doc: shell need single quote to use $ character
2010-01-17 7:14 ` Ingo Molnar
@ 2010-01-19 2:35 ` Masami Hiramatsu
2010-01-20 7:12 ` [tip:perf/core] kprobetrace, doc: Shell needs " tip-bot for Motohiro KOSAKI
2010-01-19 2:35 ` [PATCH -tip 2/2] kprobetrace, doc: Add the explanation to remove probe points Masami Hiramatsu
1 sibling, 1 reply; 14+ messages in thread
From: Masami Hiramatsu @ 2010-01-19 2:35 UTC (permalink / raw)
To: Ingo Molnar, lkml; +Cc: systemtap, DLE, KOSAKI Motohiro, Masami Hiramatsu
From: Motohiro KOSAKI <kosaki.motohiro@jp.fujitsu.com>
shell interpret $val is as shell variable. thus we need quote if
we use echo command.
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com>
---
Documentation/trace/kprobetrace.txt | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/trace/kprobetrace.txt b/Documentation/trace/kprobetrace.txt
index f30978e..ab57f02 100644
--- a/Documentation/trace/kprobetrace.txt
+++ b/Documentation/trace/kprobetrace.txt
@@ -79,7 +79,7 @@ Usage examples
To add a probe as a new event, write a new definition to kprobe_events
as below.
- echo p:myprobe do_sys_open dfd=%ax filename=%dx flags=%cx mode=+4($stack) > /sys/kernel/debug/tracing/kprobe_events
+ echo 'p:myprobe do_sys_open dfd=%ax filename=%dx flags=%cx mode=+4($stack)' > /sys/kernel/debug/tracing/kprobe_events
This sets a kprobe on the top of do_sys_open() function with recording
1st to 4th arguments as "myprobe" event. Note, which register/stack entry is
@@ -88,7 +88,7 @@ the ABI, please try to use probe subcommand of perf-tools (you can find it
under tools/perf/).
As this example shows, users can choose more familiar names for each arguments.
- echo r:myretprobe do_sys_open $retval >> /sys/kernel/debug/tracing/kprobe_events
+ echo 'r:myretprobe do_sys_open $retval' >> /sys/kernel/debug/tracing/kprobe_events
This sets a kretprobe on the return point of do_sys_open() function with
recording return value as "myretprobe" event.
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH -tip 2/2] kprobetrace, doc: Add the explanation to remove probe points
2010-01-17 7:14 ` Ingo Molnar
2010-01-19 2:35 ` [PATCH -tip 1/2] kprobetrace, doc: " Masami Hiramatsu
@ 2010-01-19 2:35 ` Masami Hiramatsu
2010-01-19 2:45 ` Li Zefan
` (2 more replies)
1 sibling, 3 replies; 14+ messages in thread
From: Masami Hiramatsu @ 2010-01-19 2:35 UTC (permalink / raw)
To: Ingo Molnar, lkml; +Cc: systemtap, DLE, KOSAKI Motohiro, Masami Hiramatsu
From: Motohiro KOSAKI <kosaki.motohiro@jp.fujitsu.com>
Latest kprobetrace can remove probe points selectively. thus
documentation should be updated too.
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Acked-by: Masami Hiramatsu <mhiramat@redhat.com>
---
Documentation/trace/kprobetrace.txt | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/Documentation/trace/kprobetrace.txt b/Documentation/trace/kprobetrace.txt
index ab57f02..a9100b2 100644
--- a/Documentation/trace/kprobetrace.txt
+++ b/Documentation/trace/kprobetrace.txt
@@ -24,6 +24,7 @@ Synopsis of kprobe_events
-------------------------
p[:[GRP/]EVENT] SYMBOL[+offs]|MEMADDR [FETCHARGS] : Set a probe
r[:[GRP/]EVENT] SYMBOL[+0] [FETCHARGS] : Set a return probe
+ -:[GRP/]EVENT : Clear a probe
GRP : Group name. If omitted, use "kprobes" for it.
EVENT : Event name. If omitted, the event name is generated
@@ -122,6 +123,12 @@ REC->dfd, REC->filename, REC->flags, REC->mode
This clears all probe points.
+ Or,
+
+ echo -:myprobe >> kprobe_events
+
+ This clears probe points selectively.
+
Right after definition, each event is disabled by default. For tracing these
events, you need to enable it.
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH -tip 2/2] kprobetrace, doc: Add the explanation to remove probe points
2010-01-19 2:35 ` [PATCH -tip 2/2] kprobetrace, doc: Add the explanation to remove probe points Masami Hiramatsu
@ 2010-01-19 2:45 ` Li Zefan
2010-01-19 3:05 ` Masami Hiramatsu
2010-01-19 4:22 ` Masami Hiramatsu
2010-01-20 7:12 ` [tip:perf/core] " tip-bot for Motohiro KOSAKI
2 siblings, 1 reply; 14+ messages in thread
From: Li Zefan @ 2010-01-19 2:45 UTC (permalink / raw)
To: Masami Hiramatsu; +Cc: Ingo Molnar, lkml, systemtap, DLE, KOSAKI Motohiro
Masami Hiramatsu wrote:
> From: Motohiro KOSAKI <kosaki.motohiro@jp.fujitsu.com>
>
> Latest kprobetrace can remove probe points selectively. thus
> documentation should be updated too.
>
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> Acked-by: Masami Hiramatsu <mhiramat@redhat.com>
You should add your sob instead of ack. :)
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH -tip 2/2] kprobetrace, doc: Add the explanation to remove probe points
2010-01-19 2:45 ` Li Zefan
@ 2010-01-19 3:05 ` Masami Hiramatsu
2010-01-19 3:05 ` Li Zefan
0 siblings, 1 reply; 14+ messages in thread
From: Masami Hiramatsu @ 2010-01-19 3:05 UTC (permalink / raw)
To: Li Zefan; +Cc: Ingo Molnar, lkml, systemtap, DLE, KOSAKI Motohiro
Li Zefan wrote:
> Masami Hiramatsu wrote:
>> From: Motohiro KOSAKI <kosaki.motohiro@jp.fujitsu.com>
>>
>> Latest kprobetrace can remove probe points selectively. thus
>> documentation should be updated too.
>>
>> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
>> Acked-by: Masami Hiramatsu <mhiramat@redhat.com>
>
> You should add your sob instead of ack. :)
Ah, I didn't change anything on this patch.
Just resent :-)
Thank you,
--
Masami Hiramatsu
Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division
e-mail: mhiramat@redhat.com
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH -tip 2/2] kprobetrace, doc: Add the explanation to remove probe points
2010-01-19 3:05 ` Masami Hiramatsu
@ 2010-01-19 3:05 ` Li Zefan
0 siblings, 0 replies; 14+ messages in thread
From: Li Zefan @ 2010-01-19 3:05 UTC (permalink / raw)
To: Masami Hiramatsu; +Cc: Ingo Molnar, lkml, systemtap, DLE, KOSAKI Motohiro
Masami Hiramatsu wrote:
> Li Zefan wrote:
>> Masami Hiramatsu wrote:
>>> From: Motohiro KOSAKI <kosaki.motohiro@jp.fujitsu.com>
>>>
>>> Latest kprobetrace can remove probe points selectively. thus
>>> documentation should be updated too.
>>>
>>> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
>>> Acked-by: Masami Hiramatsu <mhiramat@redhat.com>
>> You should add your sob instead of ack. :)
>
> Ah, I didn't change anything on this patch.
> Just resent :-)
>
Still you should add your sob, since you are delivering the patch,
Andrew one reminded me on this. Also you can refer to
Documentation/SubmittingPatches:
The Signed-off-by: tag indicates that the signer was involved in the
development of the patch, or that he/she was in the patch's delivery path.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH -tip 2/2] kprobetrace, doc: Add the explanation to remove probe points
2010-01-19 2:35 ` [PATCH -tip 2/2] kprobetrace, doc: Add the explanation to remove probe points Masami Hiramatsu
2010-01-19 2:45 ` Li Zefan
@ 2010-01-19 4:22 ` Masami Hiramatsu
2010-01-20 6:18 ` Ingo Molnar
2010-01-20 7:12 ` [tip:perf/core] " tip-bot for Motohiro KOSAKI
2 siblings, 1 reply; 14+ messages in thread
From: Masami Hiramatsu @ 2010-01-19 4:22 UTC (permalink / raw)
To: Masami Hiramatsu; +Cc: Ingo Molnar, lkml, systemtap, DLE, KOSAKI Motohiro
Masami Hiramatsu wrote:
> From: Motohiro KOSAKI <kosaki.motohiro@jp.fujitsu.com>
>
> Latest kprobetrace can remove probe points selectively. thus
> documentation should be updated too.
>
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com>
Since I've delivered this patch.:-)
> ---
>
> Documentation/trace/kprobetrace.txt | 7 +++++++
> 1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/Documentation/trace/kprobetrace.txt b/Documentation/trace/kprobetrace.txt
> index ab57f02..a9100b2 100644
> --- a/Documentation/trace/kprobetrace.txt
> +++ b/Documentation/trace/kprobetrace.txt
> @@ -24,6 +24,7 @@ Synopsis of kprobe_events
> -------------------------
> p[:[GRP/]EVENT] SYMBOL[+offs]|MEMADDR [FETCHARGS] : Set a probe
> r[:[GRP/]EVENT] SYMBOL[+0] [FETCHARGS] : Set a return probe
> + -:[GRP/]EVENT : Clear a probe
>
> GRP : Group name. If omitted, use "kprobes" for it.
> EVENT : Event name. If omitted, the event name is generated
> @@ -122,6 +123,12 @@ REC->dfd, REC->filename, REC->flags, REC->mode
>
> This clears all probe points.
>
> + Or,
> +
> + echo -:myprobe >> kprobe_events
> +
> + This clears probe points selectively.
> +
> Right after definition, each event is disabled by default. For tracing these
> events, you need to enable it.
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Masami Hiramatsu
Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division
e-mail: mhiramat@redhat.com
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH -tip 2/2] kprobetrace, doc: Add the explanation to remove probe points
2010-01-19 4:22 ` Masami Hiramatsu
@ 2010-01-20 6:18 ` Ingo Molnar
0 siblings, 0 replies; 14+ messages in thread
From: Ingo Molnar @ 2010-01-20 6:18 UTC (permalink / raw)
To: Masami Hiramatsu; +Cc: lkml, systemtap, DLE, KOSAKI Motohiro
* Masami Hiramatsu <mhiramat@redhat.com> wrote:
> Masami Hiramatsu wrote:
> > From: Motohiro KOSAKI <kosaki.motohiro@jp.fujitsu.com>
> >
> > Latest kprobetrace can remove probe points selectively. thus
> > documentation should be updated too.
> >
> > Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
>
> Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com>
>
> Since I've delivered this patch.:-)
Correct - thanks guys!
Ingo
^ permalink raw reply [flat|nested] 14+ messages in thread
* [tip:perf/core] kprobetrace, doc: Shell needs single quote to use $ character
2010-01-19 2:35 ` [PATCH -tip 1/2] kprobetrace, doc: " Masami Hiramatsu
@ 2010-01-20 7:12 ` tip-bot for Motohiro KOSAKI
0 siblings, 0 replies; 14+ messages in thread
From: tip-bot for Motohiro KOSAKI @ 2010-01-20 7:12 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, hpa, mingo, dle-develop, tglx, kosaki.motohiro,
mhiramat, mingo, systemtap
Commit-ID: 580d9e00fdfb85e65c5097dcd739c6efcdbadc96
Gitweb: http://git.kernel.org/tip/580d9e00fdfb85e65c5097dcd739c6efcdbadc96
Author: Motohiro KOSAKI <kosaki.motohiro@jp.fujitsu.com>
AuthorDate: Mon, 18 Jan 2010 21:35:05 -0500
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Wed, 20 Jan 2010 07:18:14 +0100
kprobetrace, doc: Shell needs single quote to use $ character
Shell interprets $val as shell variable, thus we need quote if
we use the echo command.
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com>
Cc: systemtap <systemtap@sources.redhat.com>
Cc: DLE <dle-develop@lists.sourceforge.net>
LKML-Reference: <20100119023505.31880.17367.stgit@localhost6.localdomain6>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
Documentation/trace/kprobetrace.txt | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/trace/kprobetrace.txt b/Documentation/trace/kprobetrace.txt
index f30978e..ab57f02 100644
--- a/Documentation/trace/kprobetrace.txt
+++ b/Documentation/trace/kprobetrace.txt
@@ -79,7 +79,7 @@ Usage examples
To add a probe as a new event, write a new definition to kprobe_events
as below.
- echo p:myprobe do_sys_open dfd=%ax filename=%dx flags=%cx mode=+4($stack) > /sys/kernel/debug/tracing/kprobe_events
+ echo 'p:myprobe do_sys_open dfd=%ax filename=%dx flags=%cx mode=+4($stack)' > /sys/kernel/debug/tracing/kprobe_events
This sets a kprobe on the top of do_sys_open() function with recording
1st to 4th arguments as "myprobe" event. Note, which register/stack entry is
@@ -88,7 +88,7 @@ the ABI, please try to use probe subcommand of perf-tools (you can find it
under tools/perf/).
As this example shows, users can choose more familiar names for each arguments.
- echo r:myretprobe do_sys_open $retval >> /sys/kernel/debug/tracing/kprobe_events
+ echo 'r:myretprobe do_sys_open $retval' >> /sys/kernel/debug/tracing/kprobe_events
This sets a kretprobe on the return point of do_sys_open() function with
recording return value as "myretprobe" event.
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [tip:perf/core] kprobetrace, doc: Add the explanation to remove probe points
2010-01-19 2:35 ` [PATCH -tip 2/2] kprobetrace, doc: Add the explanation to remove probe points Masami Hiramatsu
2010-01-19 2:45 ` Li Zefan
2010-01-19 4:22 ` Masami Hiramatsu
@ 2010-01-20 7:12 ` tip-bot for Motohiro KOSAKI
2 siblings, 0 replies; 14+ messages in thread
From: tip-bot for Motohiro KOSAKI @ 2010-01-20 7:12 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, hpa, mingo, dle-develop, tglx, kosaki.motohiro,
mhiramat, mingo, systemtap
Commit-ID: df3ab708b787a2b35de5101452bd51d4a8ae0ded
Gitweb: http://git.kernel.org/tip/df3ab708b787a2b35de5101452bd51d4a8ae0ded
Author: Motohiro KOSAKI <kosaki.motohiro@jp.fujitsu.com>
AuthorDate: Mon, 18 Jan 2010 21:35:12 -0500
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Wed, 20 Jan 2010 07:18:15 +0100
kprobetrace, doc: Add the explanation to remove probe points
Latest kprobetrace can remove probe points selectively, thus
the documentation should be updated too.
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com>
Cc: systemtap <systemtap@sources.redhat.com>
Cc: DLE <dle-develop@lists.sourceforge.net>
LKML-Reference: <20100119023512.31880.35535.stgit@localhost6.localdomain6>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
Documentation/trace/kprobetrace.txt | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/Documentation/trace/kprobetrace.txt b/Documentation/trace/kprobetrace.txt
index ab57f02..a9100b2 100644
--- a/Documentation/trace/kprobetrace.txt
+++ b/Documentation/trace/kprobetrace.txt
@@ -24,6 +24,7 @@ Synopsis of kprobe_events
-------------------------
p[:[GRP/]EVENT] SYMBOL[+offs]|MEMADDR [FETCHARGS] : Set a probe
r[:[GRP/]EVENT] SYMBOL[+0] [FETCHARGS] : Set a return probe
+ -:[GRP/]EVENT : Clear a probe
GRP : Group name. If omitted, use "kprobes" for it.
EVENT : Event name. If omitted, the event name is generated
@@ -122,6 +123,12 @@ REC->dfd, REC->filename, REC->flags, REC->mode
This clears all probe points.
+ Or,
+
+ echo -:myprobe >> kprobe_events
+
+ This clears probe points selectively.
+
Right after definition, each event is disabled by default. For tracing these
events, you need to enable it.
^ permalink raw reply related [flat|nested] 14+ messages in thread
end of thread, other threads:[~2010-01-20 7:14 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-14 2:14 [resend][PATCH 1/2] kprobetrace,doc: shell need single quote to use $ character KOSAKI Motohiro
2010-01-14 2:16 ` [resend][PATCH 2/2] kprobetrace, doc: Add the explanation to remove probe points KOSAKI Motohiro
2010-01-14 5:00 ` [resend][PATCH 1/2] kprobetrace,doc: shell need single quote to use $ character Masami Hiramatsu
2010-01-14 5:17 ` KOSAKI Motohiro
2010-01-17 7:14 ` Ingo Molnar
2010-01-19 2:35 ` [PATCH -tip 1/2] kprobetrace, doc: " Masami Hiramatsu
2010-01-20 7:12 ` [tip:perf/core] kprobetrace, doc: Shell needs " tip-bot for Motohiro KOSAKI
2010-01-19 2:35 ` [PATCH -tip 2/2] kprobetrace, doc: Add the explanation to remove probe points Masami Hiramatsu
2010-01-19 2:45 ` Li Zefan
2010-01-19 3:05 ` Masami Hiramatsu
2010-01-19 3:05 ` Li Zefan
2010-01-19 4:22 ` Masami Hiramatsu
2010-01-20 6:18 ` Ingo Molnar
2010-01-20 7:12 ` [tip:perf/core] " tip-bot for Motohiro KOSAKI
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox