From: "H. Peter Anvin" <hpa@zytor.com>
To: Borislav Petkov <bp@amd64.org>
Cc: mingo@elte.hu, tglx@linutronix.de, andreas.herrmann3@amd.com,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/7] x86, smp: Adjust native_wbinvd for smp_call_function-helpers
Date: Thu, 21 Jan 2010 10:07:51 -0800 [thread overview]
Message-ID: <4B5897F7.5000008@zytor.com> (raw)
In-Reply-To: <1264092093-13739-3-git-send-email-bp@amd64.org>
On 01/21/2010 08:41 AM, Borislav Petkov wrote:
> From: Borislav Petkov <borislav.petkov@amd.com>
>
> Add a wbinvd_on_cpu() helper and fold the void * arg in the wbinvd macro
> definition so that native_wbinvd can be used in the smp_call_function_*
> helpers as a pointed-to function.
>
> Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
This patch is a lot of extra uglification just to avoid a simple jump
stub -- and even then only with PV enabled -- for an operation which is
then going to perform an IPI and WBINVD. That doesn't exactly seem like
the right tradeoff.
As such, I'm going to request that you just put a simple stub function
in lib/smp.c rather than this whole patchset (well, the smp.h bit
obviously needs to stay.)
-hpa
next prev parent reply other threads:[~2010-01-21 18:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-21 16:41 [PATCH -v2 0/7] x86, cacheinfo, amd: L3 Cache Index Disable fixes Borislav Petkov
2010-01-21 16:41 ` [PATCH 1/7] x86, smp: Convert msr-smp.c to an smp library Borislav Petkov
2010-01-21 18:08 ` H. Peter Anvin
2010-01-21 16:41 ` [PATCH 2/7] x86, smp: Adjust native_wbinvd for smp_call_function-helpers Borislav Petkov
2010-01-21 18:07 ` H. Peter Anvin [this message]
2010-01-21 18:36 ` Borislav Petkov
2010-01-21 16:41 ` [PATCH 3/7] x86, smp: Add wbinvd_on_all_cpus helper Borislav Petkov
2010-01-21 16:41 ` [PATCH 4/7] intel-agp: Switch to wbinvd_on_all_cpus Borislav Petkov
2010-01-21 16:41 ` [PATCH 5/7] x86, cacheinfo: Fix disabling of L3 cache indices Borislav Petkov
2010-01-21 16:41 ` [PATCH 6/7] x86, cacheinfo: Add cache index disable sysfs attrs only to L3 caches Borislav Petkov
2010-01-21 16:41 ` [PATCH 7/7] x86, cacheinfo: Calculate L3 indexes Borislav Petkov
2010-01-21 17:57 ` [PATCH] x86, cacheinfo: Calculate L3 indices Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B5897F7.5000008@zytor.com \
--to=hpa@zytor.com \
--cc=andreas.herrmann3@amd.com \
--cc=bp@amd64.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox