From: "H. Peter Anvin" <hpa@zytor.com>
To: Christian Hofstaedtler <ch@zeha.at>
Cc: x86@kernel.org, lenb@kernel.org, tglx@linutronix.de,
linux-acpi@vger.kernel.org, venkatesh.pallipadi@intel.com,
arjan@infradead.org, bruce.w.allan@intel.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] x86: Unify reboot_type selection
Date: Thu, 21 Jan 2010 10:29:34 -0800 [thread overview]
Message-ID: <4B589D0E.2010601@zytor.com> (raw)
In-Reply-To: <1264094323-7187-1-git-send-email-ch@zeha.at>
On 01/21/2010 09:18 AM, Christian Hofstaedtler wrote:
> Unify x86_32-only and x86_32+x86_64 reboot quirks selection functions,
> so the code path is a bit easier to understand and gets a predefined
> execution order.
>
> -static struct dmi_system_id __initdata reboot_dmi_table[] = {
> +/*
> + * This table only gets used on x86_32, so only use with
> + * set_bios_reboot.
> + */
> +static struct dmi_system_id __initdata reboot_dmi_table_x86_32[] = {
> { /* Handle problems with rebooting on Dell E520's */
> .callback = set_bios_reboot,
> .ident = "Dell E520",
> @@ -270,13 +274,6 @@ static struct dmi_system_id __initdata reboot_dmi_table[] = {
> { }
> };
>
I think it would make more sense to just #ifdef off a section of a
single table, instead of having an #ifdef for a separate table and an
#ifdef for a table entry.
I don't know how big these tables are -- this is initdata after all, so
unless the tables are really small, we could just make set_bios_reboot a
noop on x86-64.
-hpa
next prev parent reply other threads:[~2010-01-21 18:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.LFD.2.00.1001061433260.4086@localhost.localdomain>
[not found] ` <1262894593-25563-1-git-send-email-ch@zeha.at>
[not found] ` <alpine.LFD.2.00.1001200007560.4265@localhost.localdomain>
2010-01-21 17:18 ` [PATCH 1/2] x86: Unify reboot_type selection Christian Hofstaedtler
2010-01-21 17:18 ` [PATCH 2/2] Default to ACPI reboots on newish X86 hardware Christian Hofstaedtler
2010-01-23 19:57 ` Len Brown
2010-01-21 18:29 ` H. Peter Anvin [this message]
2010-01-21 17:24 ` [PATCH] " Christian Hofstaedtler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B589D0E.2010601@zytor.com \
--to=hpa@zytor.com \
--cc=arjan@infradead.org \
--cc=bruce.w.allan@intel.com \
--cc=ch@zeha.at \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=venkatesh.pallipadi@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox