Re: [PATCH 2/9] pci: add failed_list to record failed one for pci_bus_assign_resources

Alex Chiang
2010-01-21T20:42:07Z

More bike shedding.

* Yinghai Lu <yinghai@kernel.org>:
> @@ -58,6 +103,13 @@ static void pbus_assign_resources_sorted(const struct pci_bus *bus)
> res = list->res;
> idx = res - &list->dev->resource[0];
> if (pci_assign_resource(list->dev, idx)) {
> + if (fail_head && !pci_is_root_bus(list->dev->bus)) {
> + /*
> + * device need to keep flags and size
> + * for next try
> + */
> + add_to_failed_list(fail_head, list->dev, res);
> + }

I don't really think you need that comment, so just strike it
completely and drop the curly braces.

if (fail_head && !pci_is_root_bus(list->dev->bus))
add_to_failed_list(fail_head, list->dev, res);

Reviewed-by: Alex Chiang <achiang@hp.com>

/ac