[REGRESSION] clockevents patch causes hang on power off

[REGRESSION] clockevents patch causes hang on power off

[Nathan Williams]

I'm having trouble with my PC crashing just as it's attempting to power off.
I managed to git bisect to this commit:

clockevents: Prevent clockevent_devices list corruption on cpu hotplug
bb6eddf7676e1c1f3e637aa93c5224488d99036f

http://patchwork.kernel.org/patch/71157/

I've tested with 2.6.33-rc5 with and without this patch to confirm
everything works when I revert the patch.

I managed to copy down some of the output, but if need be I can try
hooking up the serial port.

Call Trace:
? hrtimer_cpu_notify+0x8a/0x152
? timer_cpu_notify+0x224/0x23b
notifier_call_chain+0x2b/0x4a
raw_notifier_call_chain+0xc/0xe
_cpu_down+0x16d/0x237
disable_nonboot_cpus+0x5f/0xe6
kernel_power_off+0x1d/0x34
sys_reboot+0xf2/0x150
sched_clock_local+0x17/0x104
set_next_entity+0x31/0x9c
finish_task_switch+0x33/0x68
schedule+0x76a/0x7b8
mntput_no_expire+0x19/0xb3
filp_close+0x51/0x5b
sysenter_do_call+0x12/0x22

EIP: clockevents_notify+0x97/0xd7 SS:ESP 0068:f6737de8

In case /proc/cpuinfo is useful, I've included that below:

processor	: 0
vendor_id	: GenuineIntel
cpu family	: 15
model		: 2
model name	: Intel(R) Pentium(R) 4 CPU 2.80GHz
stepping	: 9
cpu MHz		: 2793.365
cache size	: 512 KB
physical id	: 0
siblings	: 2
core id		: 0
cpu cores	: 1
apicid		: 0
initial apicid	: 0
fdiv_bug	: no
hlt_bug		: no
f00f_bug	: no
coma_bug	: no
fpu		: yes
fpu_exception	: yes
cpuid level	: 2
wp		: yes
flags		: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov
pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe pebs bts cid
xtpr
bogomips	: 5586.73
clflush size	: 64
cache_alignment	: 128
address sizes	: 36 bits physical, 32 bits virtual
power management:

processor	: 1
vendor_id	: GenuineIntel
cpu family	: 15
model		: 2
model name	: Intel(R) Pentium(R) 4 CPU 2.80GHz
stepping	: 9
cpu MHz		: 2793.365
cache size	: 512 KB
physical id	: 0
siblings	: 2
core id		: 0
cpu cores	: 1
apicid		: 1
initial apicid	: 1
fdiv_bug	: no
hlt_bug		: no
f00f_bug	: no
coma_bug	: no
fpu		: yes
fpu_exception	: yes
cpuid level	: 2
wp		: yes
flags		: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov
pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe pebs bts cid
xtpr
bogomips	: 5584.85
clflush size	: 64
cache_alignment	: 128
address sizes	: 36 bits physical, 32 bits virtual
power management:

Regards,
Nathan

Re: [REGRESSION] clockevents patch causes hang on power off

[Ozan Çağlayan]

Nathan Williams wrote:
> I'm having trouble with my PC crashing just as it's attempting to power off.
> I managed to git bisect to this commit:
> 

http://bugzilla.kernel.org/show_bug.cgi?id=15037
http://patchwork.kernel.org/patch/71537/

Re: [REGRESSION] clockevents patch causes hang on power off

[Nathan Williams]

2010/1/23 Ozan Çağlayan <ozan@pardus.org.tr>:
> Nathan Williams wrote:
>> I'm having trouble with my PC crashing just as it's attempting to power off.
>> I managed to git bisect to this commit:
>>
>
> http://bugzilla.kernel.org/show_bug.cgi?id=15037
> http://patchwork.kernel.org/patch/71537/
>

Thanks. The patch works for me.

Re: [REGRESSION] clockevents patch causes hang on power off

[Greg KH]

On Sat, Jan 23, 2010 at 10:22:10PM +1100, Nathan Williams wrote:
> 2010/1/23 Ozan ??a??layan <ozan@pardus.org.tr>:
> > Nathan Williams wrote:
> >> I'm having trouble with my PC crashing just as it's attempting to power off.
> >> I managed to git bisect to this commit:
> >>
> >
> > http://bugzilla.kernel.org/show_bug.cgi?id=15037
> > http://patchwork.kernel.org/patch/71537/
> >
> 
> Thanks. The patch works for me.

What's the plan on getting that patch into Linus's tree for .33?

thanks,

greg k-h

Re: [REGRESSION] clockevents patch causes hang on power off

[Rafael J. Wysocki]

On Saturday 23 January 2010, Greg KH wrote:
> On Sat, Jan 23, 2010 at 10:22:10PM +1100, Nathan Williams wrote:
> > 2010/1/23 Ozan ??a??layan <ozan@pardus.org.tr>:
> > > Nathan Williams wrote:
> > >> I'm having trouble with my PC crashing just as it's attempting to power off.
> > >> I managed to git bisect to this commit:
> > >>
> > >
> > > http://bugzilla.kernel.org/show_bug.cgi?id=15037
> > > http://patchwork.kernel.org/patch/71537/
> > >
> > 
> > Thanks. The patch works for me.
> 
> What's the plan on getting that patch into Linus's tree for .33?

Well, I guess please send it to Linus with the appropriate CC list.

This is a regression that we need to address ASAP, the patch is known, no
one has objected, so the thing is pretty much clear.

Rafael

Re: [REGRESSION] clockevents patch causes hang on power off

[Marc Dionne]

On Sat, Jan 23, 2010 at 3:16 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> On Saturday 23 January 2010, Greg KH wrote:
>> On Sat, Jan 23, 2010 at 10:22:10PM +1100, Nathan Williams wrote:
>> > 2010/1/23 Ozan ??a??layan <ozan@pardus.org.tr>:
>> > > Nathan Williams wrote:
>> > >> I'm having trouble with my PC crashing just as it's attempting to power off.
>> > >> I managed to git bisect to this commit:
>> > >>
>> > >
>> > > http://bugzilla.kernel.org/show_bug.cgi?id=15037
>> > > http://patchwork.kernel.org/patch/71537/
>> > >
>> >
>> > Thanks. The patch works for me.
>>
>> What's the plan on getting that patch into Linus's tree for .33?
>
> Well, I guess please send it to Linus with the appropriate CC list.
>
> This is a regression that we need to address ASAP, the patch is known, no
> one has objected, so the thing is pretty much clear.
>
> Rafael

I notice that it's been in tip timers/urgent and timers-for-linus for
a few days, in a slightly different form.

Marc

Re: [REGRESSION] clockevents patch causes hang on power off

[Rafael J. Wysocki]

On Saturday 23 January 2010, Marc Dionne wrote:
> On Sat, Jan 23, 2010 at 3:16 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> > On Saturday 23 January 2010, Greg KH wrote:
> >> On Sat, Jan 23, 2010 at 10:22:10PM +1100, Nathan Williams wrote:
> >> > 2010/1/23 Ozan ??a??layan <ozan@pardus.org.tr>:
> >> > > Nathan Williams wrote:
> >> > >> I'm having trouble with my PC crashing just as it's attempting to power off.
> >> > >> I managed to git bisect to this commit:
> >> > >>
> >> > >
> >> > > http://bugzilla.kernel.org/show_bug.cgi?id=15037
> >> > > http://patchwork.kernel.org/patch/71537/
> >> > >
> >> >
> >> > Thanks. The patch works for me.
> >>
> >> What's the plan on getting that patch into Linus's tree for .33?
> >
> > Well, I guess please send it to Linus with the appropriate CC list.
> >
> > This is a regression that we need to address ASAP, the patch is known, no
> > one has objected, so the thing is pretty much clear.
> >
> > Rafael
> 
> I notice that it's been in tip timers/urgent and timers-for-linus for
> a few days, in a slightly different form.

Ah, I didn't notice that, thanks.

In that case it's better to wait for it to go to Linus the usual way.

Rafael

Re: [REGRESSION] clockevents patch causes hang on power off

[Thomas Gleixner]

On Sat, 23 Jan 2010, Greg KH wrote:

> On Sat, Jan 23, 2010 at 10:22:10PM +1100, Nathan Williams wrote:
> > 2010/1/23 Ozan ??a??layan <ozan@pardus.org.tr>:
> > > Nathan Williams wrote:
> > >> I'm having trouble with my PC crashing just as it's attempting to power off.
> > >> I managed to git bisect to this commit:
> > >>
> > >
> > > http://bugzilla.kernel.org/show_bug.cgi?id=15037
> > > http://patchwork.kernel.org/patch/71537/
> > >
> > 
> > Thanks. The patch works for me.
> 
> What's the plan on getting that patch into Linus's tree for .33?

Pull request is sent. Thanks,

     tglx