public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <j.w.r.degoede@hhs.nl>
To: Jaswinder Singh Rajput <jaswinderlinux@gmail.com>
Cc: George Joseph <George.joseph@fairview5.com>,
	lm-sensors@lm-sensors.org, Jean Delvare <khali@linux-fr.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [lm-sensors] Status of Andigilog asc7621 driver submitted by George	Joseph on 2008-05-29
Date: Sat, 23 Jan 2010 18:58:25 +0100	[thread overview]
Message-ID: <4B5B38C1.5080109@hhs.nl> (raw)
In-Reply-To: <3f9a31f41001230952g6321c47bq9baf5dcfdfaf5b59@mail.gmail.com>

Hi,

On 01/23/2010 06:52 PM, Jaswinder Singh Rajput wrote:
> Andigilog asc7621 driver submitted by George Joseph on 2008-05-29,
> This chip is used by various Intel Motherboards.
>
> Is it still under review and testing :
>
> http://lists.lm-sensors.org/pipermail/lm-sensors/2008-May/023257.html
>
> http://www.spinics.net/lists/lm-sensors/msg26915.html
>
> http://www.spinics.net/lists/lm-sensors/msg26916.html
>
> http://www.lm-sensors.org/wiki/Devices
>

I guess this is partly my fault, I started a review but never finished
it. One of the big problems is that George did many things completely
different to how every other single hwmon driver does things. Which made
the review harder then necessary, and more over made me wonder if we
should accept the driver in that incarnation at all.

Then a lot of things happened and I never got around to doing anything
with it at all.

I just checked my Drafts folder, and I still have my unfinished review
in there. So if there is interest I can send that, note that it is
not a complete review though (there is a note in there which part
of the code is reviewed and which still needs to be reviewed).

Regards,

Hans

  reply	other threads:[~2010-01-23 21:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-23 17:52 Status of Andigilog asc7621 driver submitted by George Joseph on 2008-05-29 Jaswinder Singh Rajput
2010-01-23 17:58 ` Hans de Goede [this message]
2010-01-24  5:05   ` [lm-sensors] " Jaswinder Singh Rajput
2010-01-24  5:44     ` Constantine A. Murenin
2010-01-24  6:23       ` Jaswinder Singh Rajput
2010-01-24  7:58         ` Constantine A. Murenin
2010-01-26 11:55     ` Hans de Goede
2010-01-24  9:30 ` Jean Delvare
2010-01-24 12:14   ` Jaswinder Singh Rajput
2010-01-24 12:22     ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B5B38C1.5080109@hhs.nl \
    --to=j.w.r.degoede@hhs.nl \
    --cc=George.joseph@fairview5.com \
    --cc=jaswinderlinux@gmail.com \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox