Re: [PATCH RFC tip/core/rcu] accelerate grace period if last non-dynticked CPU

Andi Kleen
2010-01-26T21:31:00Z

"Paul E. McKenney" <paulmck@linux.vnet.ibm.com> writes:

Kind of offtopic to the original patch, but I couldn't
resist...

> +config RCU_FAST_NO_HZ
> + bool "Accelerate last non-dyntick-idle CPU's grace periods"
> + depends on TREE_RCU && NO_HZ && SMP

Having such a thing as a config option doesn't really make
any sense to me. Who would want to recompile their kernel
to enable/disable this? If anything it should be runtime, or better
just unconditionally on.

In general RCU could probably reduce its number of "weird"
Kconfig options.

While I think I have a better understanding of RCU than a lot
of normal users I often have no clue what to set there when
building a kernel.

-Andi

--
ak@linux.intel.com -- Speaking for myself only.