From: Lai Jiangshan <laijs@cn.fujitsu.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 4/6] tracing: Change trace_seq to use separate buffer
Date: Tue, 26 Jan 2010 11:24:47 +0800 [thread overview]
Message-ID: <4B5E607F.2040204@cn.fujitsu.com> (raw)
In-Reply-To: <20100120184046.GA6194@nowhere>
Frederic Weisbecker wrote:
> On Tue, Jan 19, 2010 at 03:34:16PM +0800, Lai Jiangshan wrote:
>> @@ -3124,6 +3126,8 @@ waitagain:
>> if (cnt >= PAGE_SIZE)
>> cnt = PAGE_SIZE - 1;
>>
>> + trace_seq_reset(&iter->seq);
>> +
>
>
>
> So we actually add a trace_seq_reset here.
> This should have been in the first patch, which drops
> the memset, and eventually modified here, just to avoid
> breaking things in the middle of a patchset.
>
> Things were already broken though before the memset dropping
> patch though in other ways, so it's not that important I guess...
>
>
There is no trace_seq_reset() before this patch applied.
trace_seq_init() in the first patch, has already reset it.
Things are not broken by the first patch, if I did not misunderstand.
next prev parent reply other threads:[~2010-01-26 3:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-19 7:34 [PATCH 4/6] tracing: Change trace_seq to use separate buffer Lai Jiangshan
2010-01-20 18:40 ` Frederic Weisbecker
2010-01-26 3:24 ` Lai Jiangshan [this message]
2010-01-30 22:07 ` Frederic Weisbecker
2010-01-20 18:56 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B5E607F.2040204@cn.fujitsu.com \
--to=laijs@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox