public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Jesse Barnes <jbarnes@virtuousgeek.org>,
	Len Brown <lenb@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
	pm list <linux-pm@lists.linux-foundation.org>,
	dri-devel@lists.sourceforge.net, Eric Anholt <eric@anholt.net>,
	airlied@linux.ie
Subject: Re: [PATCH] PM / i915: Skip kernel VT switch during suspend/resume if KMS is used
Date: Tue, 26 Jan 2010 13:46:01 -0800	[thread overview]
Message-ID: <4B5F6299.6090903@zytor.com> (raw)
In-Reply-To: <20100126145842.GA11295@ucw.cz>

On 01/26/2010 06:58 AM, Pavel Machek wrote:
>>
>> That would have to be done using suspend notifiers and should depend on what
>> driver actually controls the screen at the moment.  And I guess the only case
>> in which we actually _need_ to do the kernel VT switch is when the hardware
>> is controlled by X and without KMS.
> 
> We need vt switch when display is controlled by userland app directly
> accessing hw. It may or may not be X (svgalib anyone?,
> gtk-on-framebuffer? qtopia?).
> 
> Ideally, userspace should explicitely tell us. KD_KERNEL_GRAPHICS
> console mode?
> 

It seems that the kernel would already know if it's in control of the
mode switch, no?  If userspace ever takes control and it doesn't already
notify the kernel that it is taking over, we would seem to have a much
bigger problem...

> Plus the switch is needed for any graphics app using fbcon -- I do not
> think we actually save the framebuffer over suspend. (This one should
> probably be fixed).

Quite.

	-hpa


  reply	other threads:[~2010-01-26 21:51 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-23 23:55 [PATCH] PM / i915: Skip kernel VT switch during suspend/resume if KMS is used Rafael J. Wysocki
2010-01-24  0:18 ` Alan Cox
2010-01-24 19:04   ` Rafael J. Wysocki
2010-01-25 17:22 ` Eric Anholt
2010-01-25 18:35 ` Jesse Barnes
2010-01-25 18:43   ` Alan Cox
2010-01-25 18:49     ` Jesse Barnes
2010-01-25 21:17       ` Rafael J. Wysocki
2010-01-25 21:27         ` Alan Cox
2010-01-25 21:54           ` Rafael J. Wysocki
2010-01-25 22:23             ` Alan Cox
2010-01-26 14:17             ` Pavel Machek
2010-01-26 18:47               ` Rafael J. Wysocki
2010-01-26 14:58                 ` Pavel Machek
2010-01-26 21:46                   ` H. Peter Anvin [this message]
2010-01-26 22:08                     ` Pavel Machek
2010-01-27 23:07                   ` [linux-pm] " Stefan Seyfried
2010-01-31  8:54                     ` Pavel Machek
2010-02-03 14:24                       ` Stefan Seyfried

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B5F6299.6090903@zytor.com \
    --to=hpa@zytor.com \
    --cc=airlied@linux.ie \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=dri-devel@lists.sourceforge.net \
    --cc=eric@anholt.net \
    --cc=jbarnes@virtuousgeek.org \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=pavel@ucw.cz \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox