public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Clean-up a few comments.
@ 2010-01-26 23:39 Justin P. Mattock
  2010-01-26 23:45 ` Jiri Kosina
  0 siblings, 1 reply; 4+ messages in thread
From: Justin P. Mattock @ 2010-01-26 23:39 UTC (permalink / raw)
  To: trivial; +Cc: linux-kernel, Justin P. Mattock

Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
---
 arch/x86/kernel/setup.c |    9 ++++-----
 1 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index f7b8b98..1bd37e9 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -245,7 +245,7 @@ struct edd edd;
 #ifdef CONFIG_EDD_MODULE
 EXPORT_SYMBOL(edd);
 #endif
-/**
+/*
  * copy_edd() - Copy the BIOS EDD information
  *              from boot_params into a safe place.
  *
@@ -398,8 +398,8 @@ static void __init reserve_initrd(void)
 
 	if (ramdisk_end <= end_of_lowmem) {
 		/* All in lowmem, easy case */
-		/*
-		 * don't need to reserve again, already reserved early
+		
+		/* don't need to reserve again, already reserved early
 		 * in i386_start_kernel
 		 */
 		initrd_start = ramdisk_image + PAGE_OFFSET;
@@ -665,8 +665,7 @@ static struct dmi_system_id __initdata bad_bios_dmi_table[] = {
  * for initialization.  Note, the efi init code path is determined by the
  * global efi_enabled. This allows the same kernel image to be used on existing
  * systems (with a traditional BIOS) as well as on EFI systems.
- */
-/*
+ *
  * setup_arch - architecture-specific boot-time initializations
  *
  * Note: On x86_64, fixmaps are ready for use even before this is called.
-- 
1.6.5.GIT


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] Clean-up a few comments.
  2010-01-26 23:39 [PATCH] Clean-up a few comments Justin P. Mattock
@ 2010-01-26 23:45 ` Jiri Kosina
  2010-01-27  0:01   ` Justin P. Mattock
  2010-01-27  3:11   ` Américo Wang
  0 siblings, 2 replies; 4+ messages in thread
From: Jiri Kosina @ 2010-01-26 23:45 UTC (permalink / raw)
  To: Justin P. Mattock; +Cc: linux-kernel

On Tue, 26 Jan 2010, Justin P. Mattock wrote:

> Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
> ---
>  arch/x86/kernel/setup.c |    9 ++++-----
>  1 files changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
> index f7b8b98..1bd37e9 100644
> --- a/arch/x86/kernel/setup.c
> +++ b/arch/x86/kernel/setup.c
> @@ -245,7 +245,7 @@ struct edd edd;
>  #ifdef CONFIG_EDD_MODULE
>  EXPORT_SYMBOL(edd);
>  #endif
> -/**
> +/*

There are zillions of '**' comment starters in kernel sources.

	$ git grep '/\*\*$' drivers/ | wc -l
	15506

So it doesn't seem to make sense to fix only this particular one.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Clean-up a few comments.
  2010-01-26 23:45 ` Jiri Kosina
@ 2010-01-27  0:01   ` Justin P. Mattock
  2010-01-27  3:11   ` Américo Wang
  1 sibling, 0 replies; 4+ messages in thread
From: Justin P. Mattock @ 2010-01-27  0:01 UTC (permalink / raw)
  To: Jiri Kosina; +Cc: linux-kernel

On 01/26/10 15:45, Jiri Kosina wrote:
> On Tue, 26 Jan 2010, Justin P. Mattock wrote:
>
>> Signed-off-by: Justin P. Mattock<justinmattock@gmail.com>
>> ---
>>   arch/x86/kernel/setup.c |    9 ++++-----
>>   1 files changed, 4 insertions(+), 5 deletions(-)
>>
>> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
>> index f7b8b98..1bd37e9 100644
>> --- a/arch/x86/kernel/setup.c
>> +++ b/arch/x86/kernel/setup.c
>> @@ -245,7 +245,7 @@ struct edd edd;
>>   #ifdef CONFIG_EDD_MODULE
>>   EXPORT_SYMBOL(edd);
>>   #endif
>> -/**
>> +/*
>
> There are zillions of '**' comment starters in kernel sources.
>
> 	$ git grep '/\*\*$' drivers/ | wc -l
> 	15506
>
> So it doesn't seem to make sense to fix only this particular one.
>


alright.. was just going through and noticed.
In any case I'll stick to typos if I come across any.

Justin P. Mattock

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Clean-up a few comments.
  2010-01-26 23:45 ` Jiri Kosina
  2010-01-27  0:01   ` Justin P. Mattock
@ 2010-01-27  3:11   ` Américo Wang
  1 sibling, 0 replies; 4+ messages in thread
From: Américo Wang @ 2010-01-27  3:11 UTC (permalink / raw)
  To: Jiri Kosina; +Cc: Justin P. Mattock, linux-kernel

On Wed, Jan 27, 2010 at 7:45 AM, Jiri Kosina <jkosina@suse.cz> wrote:
> On Tue, 26 Jan 2010, Justin P. Mattock wrote:
>
>> Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
>> ---
>>  arch/x86/kernel/setup.c |    9 ++++-----
>>  1 files changed, 4 insertions(+), 5 deletions(-)
>>
>> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
>> index f7b8b98..1bd37e9 100644
>> --- a/arch/x86/kernel/setup.c
>> +++ b/arch/x86/kernel/setup.c
>> @@ -245,7 +245,7 @@ struct edd edd;
>>  #ifdef CONFIG_EDD_MODULE
>>  EXPORT_SYMBOL(edd);
>>  #endif
>> -/**
>> +/*
>
> There are zillions of '**' comment starters in kernel sources.
>
>        $ git grep '/\*\*$' drivers/ | wc -l
>        15506
>
> So it doesn't seem to make sense to fix only this particular one.

Some of them are needed by kerneldoc generation, it doesn't make sense
to fix them.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2010-01-27  3:11 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-26 23:39 [PATCH] Clean-up a few comments Justin P. Mattock
2010-01-26 23:45 ` Jiri Kosina
2010-01-27  0:01   ` Justin P. Mattock
2010-01-27  3:11   ` Américo Wang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox