From: Jiri Slaby <jirislaby@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: akpm@linux-foundation.org, mm-commits@vger.kernel.org,
joe@perches.com, bzolnier@gmail.com, jens.axboe@oracle.com,
marcin.slusarz@gmail.com, shemminger@vyatta.com
Subject: Re: + drivers-block-floppyc-remove-used-once-check_ready-macro.patch added to -mm tree
Date: Wed, 27 Jan 2010 10:36:01 +0100 [thread overview]
Message-ID: <4B600901.6090804@gmail.com> (raw)
In-Reply-To: <201001270037.o0R0bS1R032523@imap1.linux-foundation.org>
On 01/27/2010 01:37 AM, akpm@linux-foundation.org wrote:
> Subject: drivers/block/floppy.c: remove used once CHECK_READY macro
> From: Joe Perches <joe@perches.com>
That the macro is used once does not necessarily mean, it should be
removed. Please add more explanation to your changelogs. It should be
something like: "remove the macro as it is totally bogus in that it
changes control flow and we usually do not expect that". For example,
there were alerady few macro incidents in floppy that changed control
flow causing locking imbalances.
--
js
parent reply other threads:[~2010-01-27 9:36 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <201001270037.o0R0bS1R032523@imap1.linux-foundation.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B600901.6090804@gmail.com \
--to=jirislaby@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bzolnier@gmail.com \
--cc=jens.axboe@oracle.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.slusarz@gmail.com \
--cc=mm-commits@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox