* Re: + drivers-block-floppyc-remove-used-once-check_ready-macro.patch added to -mm tree
[not found] <201001270037.o0R0bS1R032523@imap1.linux-foundation.org>
@ 2010-01-27 9:36 ` Jiri Slaby
0 siblings, 0 replies; only message in thread
From: Jiri Slaby @ 2010-01-27 9:36 UTC (permalink / raw)
To: linux-kernel
Cc: akpm, mm-commits, joe, bzolnier, jens.axboe, marcin.slusarz,
shemminger
On 01/27/2010 01:37 AM, akpm@linux-foundation.org wrote:
> Subject: drivers/block/floppy.c: remove used once CHECK_READY macro
> From: Joe Perches <joe@perches.com>
That the macro is used once does not necessarily mean, it should be
removed. Please add more explanation to your changelogs. It should be
something like: "remove the macro as it is totally bogus in that it
changes control flow and we usually do not expect that". For example,
there were alerady few macro incidents in floppy that changed control
flow causing locking imbalances.
--
js
^ permalink raw reply [flat|nested] only message in thread