From: Jiri Slaby <jirislaby@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
mm-commits@vger.kernel.org, bzolnier@gmail.com,
jens.axboe@oracle.com, marcin.slusarz@gmail.com,
shemminger@vyatta.com
Subject: Re: + drivers-block-floppyc-remove-copyin-copyout-and-ecall-macros.patch added to -mm tree
Date: Wed, 27 Jan 2010 16:25:57 +0100 [thread overview]
Message-ID: <4B605B05.7060601@gmail.com> (raw)
In-Reply-To: <1264603993.14552.71.camel@Joe-Laptop.home>
On 01/27/2010 03:53 PM, Joe Perches wrote:
> Do feel free to submit patches with your
> desired level of changelog prolixity.
It's not my level changelog prolixity, it's you do changes irrelevant to
your changelog and further you do not explain, why you change the code.
So (a) review process is hard and (b) nobody (mainly distro kernel
packagers) knows whether to backport some of the change to stable or not.
Look at that piece again:
Subject [PATCH 03/24] drivers/block/floppy.c: Use pr_<level>
Date Thu, 21 Jan 2010 20:52:33 -0800
Convert bare printk to pr_info and pr_cont
Convert printk(KERN_ERR to pr_err
...
if (UDP->flags & FD_DEBUG) {
- DPRINT("reschedule timeout ");
- printk(message, marg);
- printk("\n");
+ DPRINT("reschedule timeout %s %d\n", message, marg);
}
Does it look like a "Use pr_<level>" change? No and hence my confusion
by the hunk.
--
js
prev parent reply other threads:[~2010-01-27 15:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201001270037.o0R0bqQC032566@imap1.linux-foundation.org>
2010-01-27 9:43 ` + drivers-block-floppyc-remove-copyin-copyout-and-ecall-macros.patch added to -mm tree Jiri Slaby
2010-01-27 14:53 ` Joe Perches
2010-01-27 15:25 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B605B05.7060601@gmail.com \
--to=jirislaby@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bzolnier@gmail.com \
--cc=jens.axboe@oracle.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.slusarz@gmail.com \
--cc=mm-commits@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox