From: Thomas Hellstrom <thellstrom@vmware.com>
To: Richard Kennedy <richard@rsk.demon.co.uk>
Cc: David Airlie <airlied@linux.ie>,
lkml <linux-kernel@vger.kernel.org>,
"dri-devel@lists.sourceforge.net"
<dri-devel@lists.sourceforge.net>
Subject: Re: [PATCH] drm/ttm: remove padding from ttm_ref_object on 64bit builds
Date: Sat, 30 Jan 2010 16:19:45 +0100 [thread overview]
Message-ID: <4B644E11.5060002@vmware.com> (raw)
In-Reply-To: <1264525848.2044.5.camel@localhost>
Richard Kennedy wrote:
> Re-order structure ttm_ref_object to remove 8 bytes of alignment padding
> on 64 bit builds, so shrinking its size from 72 to 64 bytes allowing it
> to fit into a smaller slab.
>
> Signed-off-by: Richard Kennedy <richard@rsk.demon.co.uk>
> ----
> patch against 2.6.33-rc5
> compiled & tested on x86_64 AMDX2 and nouveau
> regards
> Richard
>
>
> diff --git a/drivers/gpu/drm/ttm/ttm_object.c b/drivers/gpu/drm/ttm/ttm_object.c
> index 1099aba..75e9d6f 100644
> --- a/drivers/gpu/drm/ttm/ttm_object.c
> +++ b/drivers/gpu/drm/ttm/ttm_object.c
> @@ -109,8 +109,8 @@ struct ttm_ref_object {
> struct drm_hash_item hash;
> struct list_head head;
> struct kref kref;
> - struct ttm_base_object *obj;
> enum ttm_ref_type ref_type;
> + struct ttm_base_object *obj;
> struct ttm_object_file *tfile;
> };
>
>
>
>
Acked-by: Thomas Hellstrom <thellstrom@vmware.com>
prev parent reply other threads:[~2010-01-30 15:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-26 17:10 [PATCH] drm/ttm: remove padding from ttm_ref_object on 64bit builds Richard Kennedy
2010-01-30 15:19 ` Thomas Hellstrom [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B644E11.5060002@vmware.com \
--to=thellstrom@vmware.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=richard@rsk.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox