* [PATCH] scripts: use %_tmppath in "make rpm-pkg"
@ 2010-02-01 0:18 John Saalwaechter
2010-02-01 12:52 ` Michal Marek
0 siblings, 1 reply; 2+ messages in thread
From: John Saalwaechter @ 2010-02-01 0:18 UTC (permalink / raw)
To: linux-kernel
The mkspec script hardcodes "/var/tmp" into the generated rpm spec file's
BuildRoot. The user, however, may have a custom setting for %_tmppath,
which should be used in BuildRoot. This patch changes mkspec's
BuildRoot output to appropriately use %_tmppath.
Signed-off-by: John Saalwaechter <saalwaechter@gmail.com>
---
diff -uprN a/scripts/package/mkspec b/scripts/package/mkspec
--- a/scripts/package/mkspec 2010-01-28 15:06:20.000000000 -0800
+++ b/scripts/package/mkspec 2010-01-31 15:46:23.815300460 -0800
@@ -39,7 +39,7 @@ if ! $PREBUILT; then
echo "Source: kernel-$__KERNELRELEASE.tar.gz"
fi
-echo "BuildRoot: /var/tmp/%{name}-%{PACKAGE_VERSION}-root"
+echo "BuildRoot: %{_tmppath}/%{name}-%{PACKAGE_VERSION}-root"
echo "Provides: $PROVIDES"
echo "%define __spec_install_post /usr/lib/rpm/brp-compress || :"
echo "%define debug_package %{nil}"
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] scripts: use %_tmppath in "make rpm-pkg"
2010-02-01 0:18 [PATCH] scripts: use %_tmppath in "make rpm-pkg" John Saalwaechter
@ 2010-02-01 12:52 ` Michal Marek
0 siblings, 0 replies; 2+ messages in thread
From: Michal Marek @ 2010-02-01 12:52 UTC (permalink / raw)
To: John Saalwaechter; +Cc: lkml, linux-kbuild
On 1.2.2010 01:18, John Saalwaechter wrote:
> The mkspec script hardcodes "/var/tmp" into the generated rpm spec file's
> BuildRoot. The user, however, may have a custom setting for %_tmppath,
> which should be used in BuildRoot. This patch changes mkspec's
> BuildRoot output to appropriately use %_tmppath.
Thanks, applied. Please CC linux-kbuild@ on changes like this.
Michal
> Signed-off-by: John Saalwaechter <saalwaechter@gmail.com>
> ---
> diff -uprN a/scripts/package/mkspec b/scripts/package/mkspec
> --- a/scripts/package/mkspec 2010-01-28 15:06:20.000000000 -0800
> +++ b/scripts/package/mkspec 2010-01-31 15:46:23.815300460 -0800
> @@ -39,7 +39,7 @@ if ! $PREBUILT; then
> echo "Source: kernel-$__KERNELRELEASE.tar.gz"
> fi
>
> -echo "BuildRoot: /var/tmp/%{name}-%{PACKAGE_VERSION}-root"
> +echo "BuildRoot: %{_tmppath}/%{name}-%{PACKAGE_VERSION}-root"
> echo "Provides: $PROVIDES"
> echo "%define __spec_install_post /usr/lib/rpm/brp-compress || :"
> echo "%define debug_package %{nil}"
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-02-01 12:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-01 0:18 [PATCH] scripts: use %_tmppath in "make rpm-pkg" John Saalwaechter
2010-02-01 12:52 ` Michal Marek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox