Re: [PATCH] Constify struct mtrr_ops for v2.6.33-rc6

["H. Peter Anvin" <hpa@zytor.com>]

On 01/31/2010 11:16 AM, Emese Revfy wrote:
> From: Emese Revfy <re.emese@gmail.com>
> 
> Constify struct mtrr_ops.
> 
> This is part of the ops structure constification
> effort started by Arjan van de Ven et al.
> 
> Benefits of this constification:
> 
>  * prevents modification of data that is shared
>    (referenced) by many other structure instances
>    at runtime
> 
>  * detects/prevents accidental (but not intentional)
>    modification attempts on archs that enforce
>    read-only kernel data at runtime
> 
>  * potentially better optimized code as the compiler
>    can assume that the const data cannot be changed
> 
>  * the compiler/linker move const data into .rodata
>    and therefore exclude them from false sharing
> 
> Signed-off-by: Emese Revfy <re.emese@gmail.com>
> Acked-by: H. Peter Anvin <hpa@zytor.com>

Yes, but this doesn't exactly seem like 2.6.33 matter.  I will put it in
-tip for 2.6.34.

	-hpa