* [PATCH] i915: slow acpi_lid_open() causes flickering
@ 2010-02-01 18:20 Thomas Meyer
2010-02-01 22:33 ` Andrew Morton
2010-02-04 15:43 ` Eric Anholt
0 siblings, 2 replies; 7+ messages in thread
From: Thomas Meyer @ 2010-02-01 18:20 UTC (permalink / raw)
To: Jesse Barnes, Eric Anholt, Linux Kernel Mailing List; +Cc: Rafael J. Wysocki
acpi_lid_open() could take up to 10ms on my computer.
Some component is calling the drm GETCONNECTOR ioctl many times in a row.
This results in flickering (for example, when starting a video).
Fix it by assuming an always connected lid status.
This fixes bug http://bugzilla.kernel.org/show_bug.cgi?id=14670
---
drivers/gpu/drm/i915/intel_lvds.c | 15 ++++++++++++++-
1 files changed, 14 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c
index aa74e59..0f0779c 100644
--- a/drivers/gpu/drm/i915/intel_lvds.c
+++ b/drivers/gpu/drm/i915/intel_lvds.c
@@ -632,6 +632,18 @@ static const struct dmi_system_id bad_lid_status[] = {
{ }
};
+/* Some lid devices take a long time to report the lid status, assume they're connected*/
+static const struct dmi_system_id slow_lid_status[] = {
+ {
+ .ident = "Aspire 1810T",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "Aspire 1810T"),
+ },
+ },
+ { }
+};
+
/**
* Detect the LVDS connection.
*
@@ -643,7 +655,8 @@ static enum drm_connector_status intel_lvds_detect(struct drm_connector *connect
{
enum drm_connector_status status = connector_status_connected;
- if (!acpi_lid_open() && !dmi_check_system(bad_lid_status))
+ if (!dmi_check_system(slow_lid_status) && !dmi_check_system(bad_lid_status))
+ if (!acpi_lid_open())
status = connector_status_disconnected;
return status;
--
1.6.6
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] i915: slow acpi_lid_open() causes flickering
2010-02-01 18:20 [PATCH] i915: slow acpi_lid_open() causes flickering Thomas Meyer
@ 2010-02-01 22:33 ` Andrew Morton
2010-02-02 0:00 ` Justin P. Mattock
2010-02-02 0:07 ` Joe Perches
2010-02-04 15:43 ` Eric Anholt
1 sibling, 2 replies; 7+ messages in thread
From: Andrew Morton @ 2010-02-01 22:33 UTC (permalink / raw)
To: Thomas Meyer
Cc: Jesse Barnes, Eric Anholt, Linux Kernel Mailing List,
Rafael J. Wysocki
On Mon, 01 Feb 2010 19:20:53 +0100
Thomas Meyer <thomas@m3y3r.de> wrote:
> acpi_lid_open() could take up to 10ms on my computer.
> Some component is calling the drm GETCONNECTOR ioctl many times in a row.
> This results in flickering (for example, when starting a video).
> Fix it by assuming an always connected lid status.
>
> This fixes bug http://bugzilla.kernel.org/show_bug.cgi?id=14670
>
> ---
> drivers/gpu/drm/i915/intel_lvds.c | 15 ++++++++++++++-
> 1 files changed, 14 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c
> index aa74e59..0f0779c 100644
> --- a/drivers/gpu/drm/i915/intel_lvds.c
> +++ b/drivers/gpu/drm/i915/intel_lvds.c
> @@ -632,6 +632,18 @@ static const struct dmi_system_id bad_lid_status[] = {
> { }
> };
>
> +/* Some lid devices take a long time to report the lid status, assume they're connected*/
> +static const struct dmi_system_id slow_lid_status[] = {
> + {
> + .ident = "Aspire 1810T",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "Aspire 1810T"),
> + },
> + },
> + { }
> +};
> +
> /**
> * Detect the LVDS connection.
> *
> @@ -643,7 +655,8 @@ static enum drm_connector_status intel_lvds_detect(struct drm_connector *connect
> {
> enum drm_connector_status status = connector_status_connected;
>
> - if (!acpi_lid_open() && !dmi_check_system(bad_lid_status))
> + if (!dmi_check_system(slow_lid_status) && !dmi_check_system(bad_lid_status))
> + if (!acpi_lid_open())
> status = connector_status_disconnected;
>
> return status;
The patch is missing your Signed-off-by: line. I cheekily added it.
Please check Documentation/SubmittingPatches, let me know if you
disagree with this, thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] i915: slow acpi_lid_open() causes flickering
2010-02-01 22:33 ` Andrew Morton
@ 2010-02-02 0:00 ` Justin P. Mattock
2010-02-02 17:30 ` Thomas Meyer
2010-02-02 0:07 ` Joe Perches
1 sibling, 1 reply; 7+ messages in thread
From: Justin P. Mattock @ 2010-02-02 0:00 UTC (permalink / raw)
To: Andrew Morton
Cc: Thomas Meyer, Jesse Barnes, Eric Anholt,
Linux Kernel Mailing List, Rafael J. Wysocki
On 02/01/10 14:33, Andrew Morton wrote:
> On Mon, 01 Feb 2010 19:20:53 +0100
> Thomas Meyer<thomas@m3y3r.de> wrote:
>
>> acpi_lid_open() could take up to 10ms on my computer.
>> Some component is calling the drm GETCONNECTOR ioctl many times in a row.
>> This results in flickering (for example, when starting a video).
>> Fix it by assuming an always connected lid status.
>>
>> This fixes bug http://bugzilla.kernel.org/show_bug.cgi?id=14670
>>
>> ---
>> drivers/gpu/drm/i915/intel_lvds.c | 15 ++++++++++++++-
>> 1 files changed, 14 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c
>> index aa74e59..0f0779c 100644
>> --- a/drivers/gpu/drm/i915/intel_lvds.c
>> +++ b/drivers/gpu/drm/i915/intel_lvds.c
>> @@ -632,6 +632,18 @@ static const struct dmi_system_id bad_lid_status[] = {
>> { }
>> };
>>
>> +/* Some lid devices take a long time to report the lid status, assume they're connected*/
>> +static const struct dmi_system_id slow_lid_status[] = {
>> + {
>> + .ident = "Aspire 1810T",
>> + .matches = {
>> + DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
>> + DMI_MATCH(DMI_PRODUCT_NAME, "Aspire 1810T"),
>> + },
>> + },
>> + { }
>> +};
>> +
>> /**
>> * Detect the LVDS connection.
>> *
>> @@ -643,7 +655,8 @@ static enum drm_connector_status intel_lvds_detect(struct drm_connector *connect
>> {
>> enum drm_connector_status status = connector_status_connected;
>>
>> - if (!acpi_lid_open()&& !dmi_check_system(bad_lid_status))
>> + if (!dmi_check_system(slow_lid_status)&& !dmi_check_system(bad_lid_status))
>> + if (!acpi_lid_open())
>> status = connector_status_disconnected;
>>
>> return status;
>
> The patch is missing your Signed-off-by: line. I cheekily added it.
> Please check Documentation/SubmittingPatches, let me know if you
> disagree with this, thanks.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
I'm wondering if just adding your DMI entry to
bad_lid_status[] is all that is really needed.
(this way it saves bits in the kernel).
Justin P. Mattock
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] i915: slow acpi_lid_open() causes flickering
2010-02-01 22:33 ` Andrew Morton
2010-02-02 0:00 ` Justin P. Mattock
@ 2010-02-02 0:07 ` Joe Perches
2010-02-02 17:33 ` Thomas Meyer
1 sibling, 1 reply; 7+ messages in thread
From: Joe Perches @ 2010-02-02 0:07 UTC (permalink / raw)
To: Andrew Morton
Cc: Thomas Meyer, Jesse Barnes, Eric Anholt,
Linux Kernel Mailing List, Rafael J. Wysocki
On Mon, 2010-02-01 at 14:33 -0800, Andrew Morton wrote:
> On Mon, 01 Feb 2010 19:20:53 +0100
> Thomas Meyer <thomas@m3y3r.de> wrote:
> > acpi_lid_open() could take up to 10ms on my computer.
> > Some component is calling the drm GETCONNECTOR ioctl many times in a row.
> > This results in flickering (for example, when starting a video).
> > Fix it by assuming an always connected lid status.
> >
> > This fixes bug http://bugzilla.kernel.org/show_bug.cgi?id=14670
> >
> > ---
> > drivers/gpu/drm/i915/intel_lvds.c | 15 ++++++++++++++-
> > 1 files changed, 14 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c
> > index aa74e59..0f0779c 100644
> > --- a/drivers/gpu/drm/i915/intel_lvds.c
> > +++ b/drivers/gpu/drm/i915/intel_lvds.c
[]
> > @@ -643,7 +655,8 @@ static enum drm_connector_status intel_lvds_detect(struct drm_connector *connect
> > {
> > enum drm_connector_status status = connector_status_connected;
> >
> > - if (!acpi_lid_open() && !dmi_check_system(bad_lid_status))
> > + if (!dmi_check_system(slow_lid_status) && !dmi_check_system(bad_lid_status))
> > + if (!acpi_lid_open())
> > status = connector_status_disconnected;
> >
> > return status;
Shouldn't this use an && test instead of a 4 space indent of a new statement?
+ if (!dmi_check_system(slow_lid_status) && !dmi_check_system(bad_lid_status) &&
+ !acpi_lid_open())
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] i915: slow acpi_lid_open() causes flickering
2010-02-02 0:00 ` Justin P. Mattock
@ 2010-02-02 17:30 ` Thomas Meyer
0 siblings, 0 replies; 7+ messages in thread
From: Thomas Meyer @ 2010-02-02 17:30 UTC (permalink / raw)
To: Justin P. Mattock
Cc: Andrew Morton, Jesse Barnes, Eric Anholt,
Linux Kernel Mailing List, Rafael J. Wysocki
Am Montag, den 01.02.2010, 16:00 -0800 schrieb Justin P. Mattock:
> On 02/01/10 14:33, Andrew Morton wrote:
> > On Mon, 01 Feb 2010 19:20:53 +0100
> > Thomas Meyer<thomas@m3y3r.de> wrote:
> >
> >> acpi_lid_open() could take up to 10ms on my computer.
> >> Some component is calling the drm GETCONNECTOR ioctl many times in a row.
> >> This results in flickering (for example, when starting a video).
> >> Fix it by assuming an always connected lid status.
> >>
> >> This fixes bug http://bugzilla.kernel.org/show_bug.cgi?id=14670
> >>
> >> ---
> >> drivers/gpu/drm/i915/intel_lvds.c | 15 ++++++++++++++-
> >> 1 files changed, 14 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c
> >> index aa74e59..0f0779c 100644
> >> --- a/drivers/gpu/drm/i915/intel_lvds.c
> >> +++ b/drivers/gpu/drm/i915/intel_lvds.c
> >> @@ -632,6 +632,18 @@ static const struct dmi_system_id bad_lid_status[] = {
> >> { }
> >> };
> >>
> >> +/* Some lid devices take a long time to report the lid status, assume they're connected*/
> >> +static const struct dmi_system_id slow_lid_status[] = {
> >> + {
> >> + .ident = "Aspire 1810T",
> >> + .matches = {
> >> + DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
> >> + DMI_MATCH(DMI_PRODUCT_NAME, "Aspire 1810T"),
> >> + },
> >> + },
> >> + { }
> >> +};
> >> +
> >> /**
> >> * Detect the LVDS connection.
> >> *
> >> @@ -643,7 +655,8 @@ static enum drm_connector_status intel_lvds_detect(struct drm_connector *connect
> >> {
> >> enum drm_connector_status status = connector_status_connected;
> >>
> >> - if (!acpi_lid_open()&& !dmi_check_system(bad_lid_status))
> >> + if (!dmi_check_system(slow_lid_status)&& !dmi_check_system(bad_lid_status))
> >> + if (!acpi_lid_open())
> >> status = connector_status_disconnected;
> >>
> >> return status;
> >
> > The patch is missing your Signed-off-by: line. I cheekily added it.
> > Please check Documentation/SubmittingPatches, let me know if you
> > disagree with this, thanks.
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at http://www.tux.org/lkml/
> >
>
> I'm wondering if just adding your DMI entry to
> bad_lid_status[] is all that is really needed.
> (this way it saves bits in the kernel).
I tried that with no success. I guess to execute the if statement the
functions acpi_lid_open() and dmi_check_system() needs to be executed
and that leads to the flickering.
maybe it helps to just reorder the if statement? first execute
dmi_check_system() and then execute acpi_lid_open(), but as both
conditions are connected via an "AND" I guess the acpi_lid_open() still
will be executed each time dmi_check_system() is executed.
mfg
thomas
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] i915: slow acpi_lid_open() causes flickering
2010-02-02 0:07 ` Joe Perches
@ 2010-02-02 17:33 ` Thomas Meyer
0 siblings, 0 replies; 7+ messages in thread
From: Thomas Meyer @ 2010-02-02 17:33 UTC (permalink / raw)
To: Joe Perches
Cc: Andrew Morton, Jesse Barnes, Eric Anholt,
Linux Kernel Mailing List, Rafael J. Wysocki
Am Montag, den 01.02.2010, 16:07 -0800 schrieb Joe Perches:
> On Mon, 2010-02-01 at 14:33 -0800, Andrew Morton wrote:
> > On Mon, 01 Feb 2010 19:20:53 +0100
> > Thomas Meyer <thomas@m3y3r.de> wrote:
> > > acpi_lid_open() could take up to 10ms on my computer.
> > > Some component is calling the drm GETCONNECTOR ioctl many times in a row.
> > > This results in flickering (for example, when starting a video).
> > > Fix it by assuming an always connected lid status.
> > >
> > > This fixes bug http://bugzilla.kernel.org/show_bug.cgi?id=14670
> > >
> > > ---
> > > drivers/gpu/drm/i915/intel_lvds.c | 15 ++++++++++++++-
> > > 1 files changed, 14 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c
> > > index aa74e59..0f0779c 100644
> > > --- a/drivers/gpu/drm/i915/intel_lvds.c
> > > +++ b/drivers/gpu/drm/i915/intel_lvds.c
> []
> > > @@ -643,7 +655,8 @@ static enum drm_connector_status intel_lvds_detect(struct drm_connector *connect
> > > {
> > > enum drm_connector_status status = connector_status_connected;
> > >
> > > - if (!acpi_lid_open() && !dmi_check_system(bad_lid_status))
> > > + if (!dmi_check_system(slow_lid_status) && !dmi_check_system(bad_lid_status))
> > > + if (!acpi_lid_open())
> > > status = connector_status_disconnected;
> > >
> > > return status;
>
> Shouldn't this use an && test instead of a 4 space indent of a new statement?
>
> + if (!dmi_check_system(slow_lid_status) && !dmi_check_system(bad_lid_status) &&
> + !acpi_lid_open())
>
Won't this lead to the execution of dmi_check_system() AND
dmi_check_system() AND acpi_lid_open() every time the
intel_lvds_detect() function is called?
And this is what I want to prevent: Do not call acpi_lid_open(), when
the system is found in the dmi table.
What do you think?
mfg
thomas
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] i915: slow acpi_lid_open() causes flickering
2010-02-01 18:20 [PATCH] i915: slow acpi_lid_open() causes flickering Thomas Meyer
2010-02-01 22:33 ` Andrew Morton
@ 2010-02-04 15:43 ` Eric Anholt
1 sibling, 0 replies; 7+ messages in thread
From: Eric Anholt @ 2010-02-04 15:43 UTC (permalink / raw)
To: Thomas Meyer, Jesse Barnes, Linux Kernel Mailing List; +Cc: Rafael J. Wysocki
[-- Attachment #1: Type: text/plain, Size: 518 bytes --]
On Mon, 01 Feb 2010 19:20:53 +0100, Thomas Meyer <thomas@m3y3r.de> wrote:
> acpi_lid_open() could take up to 10ms on my computer.
> Some component is calling the drm GETCONNECTOR ioctl many times in a row.
> This results in flickering (for example, when starting a video).
> Fix it by assuming an always connected lid status.
>
> This fixes bug http://bugzilla.kernel.org/show_bug.cgi?id=14670
If it's that unusable, this should just be put in bad_lid_status and
bad_lid_status checked before asking ACPI.
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2010-02-04 15:53 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-01 18:20 [PATCH] i915: slow acpi_lid_open() causes flickering Thomas Meyer
2010-02-01 22:33 ` Andrew Morton
2010-02-02 0:00 ` Justin P. Mattock
2010-02-02 17:30 ` Thomas Meyer
2010-02-02 0:07 ` Joe Perches
2010-02-02 17:33 ` Thomas Meyer
2010-02-04 15:43 ` Eric Anholt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox