From: "Richard Röjfors" <richard.rojfors@pelagicore.com>
To: Samuel Ortiz <samuel.ortiz@intel.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RESEND] mfd: Add support for the timberdale FPGA.
Date: Wed, 03 Feb 2010 11:53:34 +0100 [thread overview]
Message-ID: <4B6955AE.1090709@pelagicore.com> (raw)
In-Reply-To: <20100203104448.GB3460@sortiz.org>
On 02/03/2010 11:45 AM, Samuel Ortiz wrote:
> Hi Richard,
>
> On Wed, Feb 03, 2010 at 09:39:47AM +0000, Richard Röjfors wrote:
>> The timberdale FPGA is found on the Intel in-Vehicle Infotainment reference board
>> russelville.
>>
>> The driver is a PCI driver which chunks up the I/O memory and distributes interrupts
>> to a number of platform devices for each IP inside the FPGA.
>>
>> Signed-off-by: Richard Röjfors<richard.rojfors@pelagicore.com>
> The patch looks good to me, I have a couple of minor comments though:
>
> - Please replace most of your printk with dev_dbg/err()
Agreed.
> - Please fix your checkpatch output:
> total: 255 errors, 18 warnings, 822 lines checked
Sweet, the mail client changed all tabs to spaces when resending the patch.
--Richard
next prev parent reply other threads:[~2010-02-03 10:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-03 9:39 [PATCH RESEND] mfd: Add support for the timberdale FPGA Richard Röjfors
2010-02-03 10:45 ` Samuel Ortiz
2010-02-03 10:53 ` Richard Röjfors [this message]
2010-02-03 12:32 ` Samuel Ortiz
2010-02-03 12:38 ` Richard Röjfors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B6955AE.1090709@pelagicore.com \
--to=richard.rojfors@pelagicore.com \
--cc=linux-kernel@vger.kernel.org \
--cc=samuel.ortiz@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox