Re: [PATCH RESEND] mfd: Add support for the timberdale FPGA.

Samuel Ortiz
2010-02-03T12:30:54Z

On Wed, Feb 03, 2010 at 10:53:34AM +0000, Richard Röjfors wrote:
> On 02/03/2010 11:45 AM, Samuel Ortiz wrote:
> > Hi Richard,
> >
> > On Wed, Feb 03, 2010 at 09:39:47AM +0000, Richard Röjfors wrote:
> >> The timberdale FPGA is found on the Intel in-Vehicle Infotainment reference board
> >> russelville.
> >>
> >> The driver is a PCI driver which chunks up the I/O memory and distributes interrupts
> >> to a number of platform devices for each IP inside the FPGA.
> >>
> >> Signed-off-by: Richard Röjfors<richard.rojfors@pelagicore.com>
> > The patch looks good to me, I have a couple of minor comments though:
> >
> > - Please replace most of your printk with dev_dbg/err()
>
> Agreed.
>
> > - Please fix your checkpatch output:
> > total: 255 errors, 18 warnings, 822 lines checked
>
> Sweet, the mail client changed all tabs to spaces when resending the patch.
Actually, your first patch to the linux-media ml also had tabs changed into
spaces.

Cheers,
Samuel.

> --Richard
>

--
Intel Open Source Technology Centre
http://oss.intel.com/
---------------------------------------------------------------------
Intel Corporation SAS (French simplified joint stock company)
Registered headquarters: "Les Montalets"- 2, rue de Paris,
92196 Meudon Cedex, France
Registration Number: 302 456 199 R.C.S. NANTERRE
Capital: 4,572,000 Euros

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.