Re: [PATCH RESEND] mfd: Add support for the timberdale FPGA.

Richard Röjfors
2010-02-03T12:38:57Z

On 02/03/2010 01:32 PM, Samuel Ortiz wrote:
> On Wed, Feb 03, 2010 at 10:53:34AM +0000, Richard Röjfors wrote:
>> On 02/03/2010 11:45 AM, Samuel Ortiz wrote:
>>> Hi Richard,
>>>
>>> On Wed, Feb 03, 2010 at 09:39:47AM +0000, Richard Röjfors wrote:
>>>> The timberdale FPGA is found on the Intel in-Vehicle Infotainment reference board
>>>> russelville.
>>>>
>>>> The driver is a PCI driver which chunks up the I/O memory and distributes interrupts
>>>> to a number of platform devices for each IP inside the FPGA.
>>>>
>>>> Signed-off-by: Richard Röjfors<richard.rojfors@pelagicore.com>
>>> The patch looks good to me, I have a couple of minor comments though:
>>>
>>> - Please replace most of your printk with dev_dbg/err()
>>
>> Agreed.
>>
>>> - Please fix your checkpatch output:
>>> total: 255 errors, 18 warnings, 822 lines checked
>>
>> Sweet, the mail client changed all tabs to spaces when resending the patch.
> Actually, your first patch to the linux-media ml also had tabs changed into
> spaces.

I'm getting confused. I checked my sent mail and the one I got from the
media mailinglist and none of these had spaces in it.
Is there a problem with your mail client?

I'll send the updated patch off list first to verify.

--Richard