public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Paul Mackerras <paulus@samba.org>,
	Peter Zijlstra <peterz@infradead.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf tools: using O_LARGEFILE to open perf data file - fix
Date: Thu, 04 Feb 2010 10:31:07 +0800	[thread overview]
Message-ID: <4B6A316B.3040509@cn.fujitsu.com> (raw)
In-Reply-To: <20100203131911.GA25223@elte.hu>



Ingo Molnar wrote:
> * Xiao Guangrong <xiaoguangrong@cn.fujitsu.com> wrote:
> 
>> Setting _FILE_OFFSET_BITS and using O_LARGEFILE, lseek64, etc, is
>> redundant. Thanks H. Peter Anvin for point out
>>
>> Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
>> ---
>>  tools/perf/builtin-record.c        |    3 +--
>>  tools/perf/util/header.c           |   21 ++++++++++-----------
>>  tools/perf/util/session.c          |    3 +--
>>  tools/perf/util/trace-event-read.c |   14 +++++++-------
>>  4 files changed, 19 insertions(+), 22 deletions(-)
> 
> i already applied the v1 patch - mind sending a delta patch that removes the 
> redundant definitions?
> 

Hi Ingo,

This patch is the delta patch, i used the _FILE_OFFSET_BITS defining and removed
O_LARGEFILE/lseek64 to keep code clean.

I'll integrate Peter's comments and send the new version.

Thanks,
Xiao 

  reply	other threads:[~2010-02-04  2:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-03  3:53 [PATCH] perf tools: using O_LARGEFILE to open perf data file Xiao Guangrong
2010-02-03  8:45 ` [tip:perf/core] perf tools: Use " tip-bot for Xiao Guangrong
2010-02-03  9:23   ` H. Peter Anvin
2010-02-03 11:00     ` Xiao Guangrong
2010-02-03 11:06 ` [PATCH] perf tools: using O_LARGEFILE to open perf data file - fix Xiao Guangrong
2010-02-03 13:19   ` Ingo Molnar
2010-02-04  2:31     ` Xiao Guangrong [this message]
2010-02-03 17:30   ` H. Peter Anvin
2010-02-04  8:46     ` [PATCH v2] " Xiao Guangrong
2010-02-04  9:57       ` [tip:perf/core] perf tools: Clean up O_LARGEFILE et al usage tip-bot for Xiao Guangrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B6A316B.3040509@cn.fujitsu.com \
    --to=xiaoguangrong@cn.fujitsu.com \
    --cc=fweisbec@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox