From: Mark Lord <kernel@teksavvy.com>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org, Jeff Garzik <jgarzik@pobox.com>,
linux-ide@vger.kernel.org
Subject: Re: [PATCH 02/10] drivers/ata: Fix continuation line formats
Date: Wed, 03 Feb 2010 23:59:47 -0500 [thread overview]
Message-ID: <4B6A5443.6090804@teksavvy.com> (raw)
In-Reply-To: <1265224535.24887.16.camel@Joe-Laptop.home>
Joe Perches wrote:
> On Wed, 2010-02-03 at 12:21 -0500, Mark Lord wrote:
>> Joe Perches wrote:
>>> String constants that are continued on subsequent lines with \
>>> are not good.
> []
>>> - dev_warn(ap->dev, "Failed to compute ATA timing %d, \
>>> - set PIO_0 timing\n", ret);
>>> + dev_warn(ap->dev, "Failed to compute ATA timing %d, set PIO_0 timing\n",
>>> + ret);
>> NAK. Just stick the ret); part onto the same line and be done with it.
>
> :resend that I mistakenly sent only to Mark, with a couple more comments
>
> I disagree.
>
> Look at the long line wrapping style of the rest of the file
> and most of the kernel source. No additional arguments to
> functions are generally used after column 80.
>
> If it's ever agreed that all lines > 80 cols are OK or
> new args after column 80 are OK, then sure. Until then,
> if you want it, you should do it.
..
You are the code nanny trying to get this patch in. Not me.
-ml
next prev parent reply other threads:[~2010-02-04 4:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1265095093.git.joe@perches.com>
2010-02-02 7:22 ` [PATCH 01/10] arch/ia64: Fix continuation line formats Joe Perches
2010-02-07 11:43 ` Avi Kivity
2010-02-02 7:22 ` [PATCH 02/10] drivers/ata: " Joe Perches
2010-02-03 17:21 ` Mark Lord
2010-02-03 17:25 ` Jeff Garzik
2010-02-03 19:15 ` Joe Perches
2010-02-04 1:39 ` Krzysztof Halasa
2010-02-04 3:36 ` Joe Perches
2010-02-04 4:59 ` Mark Lord [this message]
2010-02-04 5:13 ` Andrew Morton
2010-02-04 14:03 ` Mark Lord
2010-02-04 5:16 ` Joe Perches
2010-02-04 14:07 ` Mark Lord
2010-02-02 7:22 ` [PATCH 03/10] drivers/gpu/drm/i915/intel_bios.c: " Joe Perches
2010-02-02 7:22 ` [PATCH 04/10] drivers/hwmon/vt8231.c: " Joe Perches
2010-02-02 7:56 ` [lm-sensors] " Jean Delvare
2010-02-02 8:01 ` Joe Perches
2010-02-02 7:22 ` [PATCH 05/10] drivers/net/davinci_emac.c: " Joe Perches
2010-02-02 7:22 ` [PATCH 06/10] drivers/scsi/qla2xxx/qua_os.c: " Joe Perches
2010-02-02 7:22 ` [PATCH 07/10] drivers/spi/spi_s3c64xx.c: " Joe Perches
2010-02-02 8:21 ` Grant Likely
2010-02-02 7:22 ` [PATCH 08/10] drivers/staging: " Joe Perches
2010-02-02 7:22 ` [PATCH 09/10] drivers/video/via: " Joe Perches
2010-02-03 22:36 ` Florian Tobias Schandinat
2010-02-02 7:22 ` [PATCH 10/10] sound/soc/s3c24xx/s2c-pcm.c: " Joe Perches
2010-02-02 11:40 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B6A5443.6090804@teksavvy.com \
--to=kernel@teksavvy.com \
--cc=jgarzik@pobox.com \
--cc=joe@perches.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox