* Re: [PATCH] Constify struct acpi_dock_ops for v2.6.33-rc6
[not found] <4B65D72B.8070000@gmail.com>
@ 2010-02-04 6:13 ` Jeff Garzik
0 siblings, 0 replies; only message in thread
From: Jeff Garzik @ 2010-02-04 6:13 UTC (permalink / raw)
To: Emese Revfy; +Cc: lenb, bjorn.helgaas, jbarnes, akpm, torvalds, linux-kernel
On 01/31/2010 02:16 PM, Emese Revfy wrote:
> From: Emese Revfy<re.emese@gmail.com>
>
> Constify struct acpi_dock_ops.
>
> This is part of the ops structure constification
> effort started by Arjan van de Ven et al.
>
> Benefits of this constification:
>
> * prevents modification of data that is shared
> (referenced) by many other structure instances
> at runtime
>
> * detects/prevents accidental (but not intentional)
> modification attempts on archs that enforce
> read-only kernel data at runtime
>
> * potentially better optimized code as the compiler
> can assume that the const data cannot be changed
>
> * the compiler/linker move const data into .rodata
> and therefore exclude them from false sharing
>
> Signed-off-by: Emese Revfy<re.emese@gmail.com>
> ---
>
> drivers/acpi/dock.c | 4 ++--
> drivers/ata/libata-acpi.c | 4 ++--
> drivers/pci/hotplug/acpiphp_glue.c | 2 +-
> include/acpi/acpi_drivers.h | 4 ++--
> 4 files changed, 7 insertions(+), 7 deletions(-)
Acked-by: Jeff Garzik <jgarzik@redhat.com>
^ permalink raw reply [flat|nested] only message in thread