From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933016Ab0BDPlk (ORCPT ); Thu, 4 Feb 2010 10:41:40 -0500 Received: from mx1.redhat.com ([209.132.183.28]:17318 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932866Ab0BDPlh (ORCPT ); Thu, 4 Feb 2010 10:41:37 -0500 Message-ID: <4B6AEA9A.90704@redhat.com> Date: Thu, 04 Feb 2010 10:41:14 -0500 From: Rik van Riel User-Agent: Thunderbird 2.0.0.21 (X11/20090320) MIME-Version: 1.0 To: balbir@linux.vnet.ibm.com CC: jdike@addtoit.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, avi@redhat.com, aarcange@redhat.com, mtosatti@redhat.com Subject: Re: [PATCH] emulate accessed bit for EPT References: <20100203161103.11e2b572@annuminas.surriel.com> <20100204041212.GI19641@balbir.in.ibm.com> <4B6ACE5B.9080601@redhat.com> <20100204153013.GK19641@balbir.in.ibm.com> In-Reply-To: <20100204153013.GK19641@balbir.in.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Balbir Singh wrote: > * Rik van Riel [2010-02-04 08:40:43]: > >> On 02/03/2010 11:12 PM, Balbir Singh wrote: >>> * Rik van Riel [2010-02-03 16:11:03]: >>> >>>> Currently KVM pretends that pages with EPT mappings never got >>>> accessed. This has some side effects in the VM, like swapping >>>> out actively used guest pages and needlessly breaking up actively >>>> used hugepages. >>>> >>>> We can avoid those very costly side effects by emulating the >>>> accessed bit for EPT PTEs, which should only be slightly costly >>>> because pages pass through page_referenced infrequently. >>> Quite a clever implementation, one side effect is that one would see a >>> larger number of minor faults with EPT enabled and an increase in >>> allocation/frees of rmap entries, but that can be easily explained. >> I suspect it won't be very many. I have been monitoring >> /proc/meminfo on my system while testing this patch, and >> it is quite typical that the size of the inactive anon >> list does not change for minutes at a time. >> >> In other words, no pages are moved onto or off of the >> inactive anon list for several minutes. That corresponds >> to a very small number of minor faults introduced by my >> patch. >> >> Of course, when the system is swapping, we will have more >> minor faults. However, minor faults should be less of a >> performance issue than major faults :) >> > > I do agree with you. After 20 hours of uptime, it appears that this patch has resolved the "KVM guests get swapped while buffer and page cache stay in memory" problem my home system was experiencing.