Re: [PATCH v1 0/7] PCI: try enabling "pci=use_crs" again

Bjorn Helgaas
2010-02-04T17:56:07Z

On Wednesday 03 February 2010 09:37:43 pm Larry Finger wrote:
> On 02/03/2010 05:38 PM, Bjorn Helgaas wrote:
> > Larry, you reported the problem the last time I tried to turn on "pci=use_crs"
> > by default. This series shouldn't affect your machine because it's not in the
> > whitelist, but I expect that if you boot the current kernel with "pci=use_crs",
> > it should still fail, and if you boot with these patches and "pci=use_crs", it
> > *should* work. I know it's a lot to ask, but it'd be great if you had a chance
> > to try that.
>
> On my system, "git describe" returns v2.6.33-rc6-146-gc80d292. Patch 1 does not
> apply and can be reverted. That is not a problem, but beginning with patch 5,
> these do not apply.

Looks like you're using Linus' tree. My patches go on top of Jesse's
PCI linux-next tree. Here's how you can do this (assuming you have
stgit as well as git):

Save all the patches in files "/tmp/use-crs.1" through "/tmp/use-crs.7".
These can be plain email; you don't have to remove headers or
anything.

$ cd <git repo>
$ git branch
$ git fetch git://git.kernel.org/pub/scm/linux/kernel/git/jbarnes/pci-2.6.git linux-next
$ stg branch -c use-crs 0148b041be4e7
$ for F in `seq 7`; do stg import -m /tmp/use-crs.$F; done

Now you should have a tree with all the patches applied.

After you're done testing, to return to where you were before, use
"git checkout <branch>" where <branch> is the name marked with a "*"
from the very first "git branch" command.

> In addition to the above, my system now boots with "pci=use_crs", unlike when I
> filed the Bugzilla.

Huh. From http://lkml.org/lkml/2009/6/24/11, I had assumed the main
problem was that we overflowed the 16-entry bus resource table, but
there must be more to it.

If you can build and boot the linux-next branch with my patches and
collect the dmesg log, maybe it will have a clue. You can boot without
"pci=use_crs"; I don't think that will make any difference on your box.

Bjorn