* [PATCH] ocfs2: Fix contiguousness check in ocfs2_try_to_merge_extent_map()
@ 2010-02-05 9:26 Roel Kluin
2010-02-05 23:24 ` Joel Becker
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2010-02-05 9:26 UTC (permalink / raw)
To: Mark Fasheh, Joel Becker, tao.ma, ocfs2-devel, Andrew Morton,
LKML
The wrong member was compared in the continguousness check.
Acked-by: Tao Ma <tao.ma@oracle.com>
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
>> } else if ((ins->ei_phys + ins->ei_clusters) == emi->ei_phys &&
>> (ins->ei_cpos + ins->ei_clusters) == emi->ei_phys &&
>> should that 2nd emi->ei_phys be emi->ei_cpos?
> oh, yes, you are right. Do you want to provide a patch?
Here, I added your ack.
diff --git a/fs/ocfs2/extent_map.c b/fs/ocfs2/extent_map.c
index d35a27f..5328529 100644
--- a/fs/ocfs2/extent_map.c
+++ b/fs/ocfs2/extent_map.c
@@ -192,7 +192,7 @@ static int ocfs2_try_to_merge_extent_map(struct ocfs2_extent_map_item *emi,
emi->ei_clusters += ins->ei_clusters;
return 1;
} else if ((ins->ei_phys + ins->ei_clusters) == emi->ei_phys &&
- (ins->ei_cpos + ins->ei_clusters) == emi->ei_phys &&
+ (ins->ei_cpos + ins->ei_clusters) == emi->ei_cpos &&
ins->ei_flags == emi->ei_flags) {
emi->ei_phys = ins->ei_phys;
emi->ei_cpos = ins->ei_cpos;
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-02-05 23:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-05 9:26 [PATCH] ocfs2: Fix contiguousness check in ocfs2_try_to_merge_extent_map() Roel Kluin
2010-02-05 23:24 ` Joel Becker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).