Re: [Patch v2] sysfs: add lockdep class support to s_active

Eric W. Biederman
2010-02-05T09:59:53Z

Cong Wang <amwang@redhat.com> writes:

> Eric W. Biederman wrote:
>> Amerigo Wang <amwang@redhat.com> writes:
>>
>>> Recently we met a lockdep warning from sysfs during s2ram or cpu hotplug.
>>> As reported by several people, it is something like:
>>
>> The interesting case is the cpu hotplug is actually a problem. It isn't
>> useful to get a complaint about the non-problems code paths triggered
>> by pm. However my earlier review spotted a real deadlock case. Where
>> in one of the sysfs attributes we iterate over the list of online cpus
>> and that appeared to an attribute that removing a cpu would remove
>> from sysfs...
>>
>
> You are referring this one:
> http://marc.info/?l=linux-kernel&m=126474021428905&w=2
> ?
>
> Hmm, yeah, I missed that the lock it is holding is not s_active, thus so
> not be the case we are trying to fix here.

Right that error appears to be legitimate. I think that is actually a
different cpu hotplug problem then the one I spotted by audit.
Spotting weird problems like that are why it is worth it for me to go
to the problem to add lockdep annotations to sysfs, and why it is
worth debugging them.

Hopefully I will have enough energy in the next little while to help
cut down on the false positive rate.

Eric