Re: [PATCH] x86: keep chip_data in create_irq_nr and destroy_irq

[Yinghai Lu <yinghai@kernel.org>]

On 02/05/2010 02:55 PM, Brandon Philips wrote:
> On 14:44 Fri 05 Feb 2010, Yinghai Lu wrote:
>> On 02/05/2010 01:09 PM, Brandon Philips wrote:
>>> @@ -77,7 +90,8 @@ void dynamic_irq_cleanup(unsigned int ir
>>>  	}
>>>  	desc->msi_desc = NULL;
>>>  	desc->handler_data = NULL;
>>> -	desc->chip_data = NULL;
>>> +	if (!keep_chip_data)
>>> +		desc->chip_data = NULL;
>>>  	desc->handle_irq = handle_bad_irq;
>>>  	desc->chip = &no_irq_chip;
>>>  	desc->name = NULL;
>>> @@ -85,6 +99,26 @@ void dynamic_irq_cleanup(unsigned int ir
>>>  	raw_spin_unlock_irqrestore(&desc->lock, flags);
>>>  }
>>>  
>>> +/**
>>> + *	dynamic_irq_cleanup - cleanup a dynamically allocated irq
>>> + *	@irq:	irq number to initialize
>>> + */
>>> +void dynamic_irq_cleanup(unsigned int irq)
>>> +{
>>> +	dynamic_irq_init_x(irq, false);
>>
>> should be dynamic_irq_cleanup_x here.
>>
>>> +}
>>> +
>>> +/**
>>> + *	dynamic_irq_cleanup_keep_chip_data - cleanup a dynamically allocated irq
>>> + *	@irq:	irq number to initialize
>>> + *
>>> + * 	does not set irq_to_desc(irq)->chip_data to NULL
>>> + */
>>> +void dynamic_irq_cleanup_keep_chip_data(unsigned int irq)
>>> +{
>>> +	dynamic_irq_init_x(irq, true);
>>
>> should be dynamic_irq_cleanup_x
> 
> Oops, right. I will fix this up along with the externs as hpa
> suggested and send again.

> 
> What are your thoughts on locking? Does it look OK as is?
> 

ok to me.

YH