From: "Jody@Tritech" <jody@nctritech.com>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] hda-intel: Avoid divide by zero crash
Date: Sat, 06 Feb 2010 10:46:26 -0500 [thread overview]
Message-ID: <4B6D8ED2.5060107@nctritech.com> (raw)
On my AMD780V chipset, hda_intel.c can crash the kernel with a divide by
zero
for as-yet unknown reasons. A simple check for zero prevents it, though
the problem that causes it remains. Since the workaround is harmless and
won't affect anyone except victims of this bug, it should be safe;
moreover,
because this crash can be triggered by a user-mode application, there are
denial of service implications on the systems affected by the bug without
the patch.
Signed-off-by: Jody Bruchon <jody@nctritech.com>
--- linux-2.6.33-rc6/sound/pci/hda/hda_intel.c 2010-01-29
16:57:50.000000000 -0500
+++ linux-2.6.33-rc6-fix/sound/pci/hda/hda_intel.c 2010-02-06
09:44:10.028348166 -0500
@@ -1878,6 +1878,12 @@
if (!bdl_pos_adj[chip->dev_index])
return 1; /* no delayed ack */
+ if (azx_dev->period_bytes == 0) {
+ printk(KERN_WARNING
+ "hda-intel: Divide by zero was avoided "
+ "in azx_dev->period_bytes.\n");
+ return 0;
+ }
if (pos % azx_dev->period_bytes > azx_dev->period_bytes / 2)
return 0; /* NG - it's below the period boundary */
return 1; /* OK, it's fine */
next reply other threads:[~2010-02-06 15:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-06 15:46 Jody@Tritech [this message]
2010-02-07 8:25 ` [PATCH] hda-intel: Avoid divide by zero crash Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B6D8ED2.5060107@nctritech.com \
--to=jody@nctritech.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox