public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dick Hollenbeck <dick@softplc.com>
To: linux-kernel@vger.kernel.org
Subject: Re: SquashFS on ARM9
Date: Sun, 07 Feb 2010 01:18:49 -0600	[thread overview]
Message-ID: <4B6E6959.60708@softplc.com> (raw)
In-Reply-To: <4B6E0F88.2020402@softplc.com>

Dick Hollenbeck wrote:
>
> Dear Philip et. al,
>
>
> I am using 2.6.30.5 on an ARM9 with squashfs.
>
> The squashFS image is built with x86_64 form of
>
>        mksquashfs version 4.1-CVS (2009/09/20)
>
> 64 bit linux program.
 >  There are no problems on the development system, only the ARM9.



OK I got more news:

The image works OK if I build it with the 32 version of mksquashs on x86.

Amazing, there are differences in file format other than endian-ness?

So we have at least 3 forms of the file system image now?  I am 
disappointed.  One would have sufficed.  I don't even buy the need for 
LSbyte vs MSbyte being needed.  There should have been only one form of 
the FS image.

Ouch, this seems amateurish.   Can I assume it is the bitfields?   Get 
rid of the bitfields!

Use #defines and OR and AND them please.

In the mksquashfs program, simply create some ints

(1<<a)
(1<<b)

etc using #defines.


Andrew Morton warned you about this years ago.  You have the bitfields 
using defines, its just that you control where the bits are:

#define MBIT (1<<2)

struct s {
    int32_t val;
} r;


r.val |= MBIT;

How hard is that really?

For now I don't need anymore help.  Sorry if I burned down my bridge, I 
only intend to offer strategy to improve the filesystem.

Dick



  reply	other threads:[~2010-02-07  7:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-07  0:55 SquashFS on ARM9 Dick Hollenbeck
2010-02-07  7:18 ` Dick Hollenbeck [this message]
2010-02-07 13:52   ` Phillip Lougher
2010-02-07 15:10     ` Dick Hollenbeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B6E6959.60708@softplc.com \
    --to=dick@softplc.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox