From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753264Ab0BGJjL (ORCPT ); Sun, 7 Feb 2010 04:39:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45476 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752479Ab0BGJjG (ORCPT ); Sun, 7 Feb 2010 04:39:06 -0500 Message-ID: <4B6E8A16.8050109@redhat.com> Date: Sun, 07 Feb 2010 11:38:30 +0200 From: Avi Kivity User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.7) Gecko/20100120 Fedora/3.0.1-1.fc12 Thunderbird/3.0.1 MIME-Version: 1.0 To: Joerg Roedel CC: Marcelo Tosatti , David Woodhouse , kvm@vger.kernel.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/11] iommu-api: Add iommu_map and iommu_unmap functions References: <1264678682-30655-1-git-send-email-joerg.roedel@amd.com> <1264678682-30655-3-git-send-email-joerg.roedel@amd.com> In-Reply-To: <1264678682-30655-3-git-send-email-joerg.roedel@amd.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/28/2010 01:37 PM, Joerg Roedel wrote: > These two functions provide support for mapping and > unmapping physical addresses to io virtual addresses. The > difference to the iommu_(un)map_range() is that the new > functions take a gfp_order parameter instead of a size. This > allows the IOMMU backend implementations to detect easier if > a given range can be mapped by larger page sizes. > These new functions should replace the old ones in the long > term. > These seem to be less flexible in the long term. Sure, it is easier for the backend to map to multiple page sizes if your iommu supports arbitrary power-of-two page sizes, but we should make the APIs easier for the callers, not the backend. -- error compiling committee.c: too many arguments to function