public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Nigel Cunningham <ncunningham@crca.org.au>
To: Bill Davidsen <davidsen@tmr.com>
Cc: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
	tuxonice-devel@lists.tuxonice.net
Subject: Re: LZO irreversible output?
Date: Mon, 08 Feb 2010 19:33:11 +1100	[thread overview]
Message-ID: <4B6FCC47.2030705@crca.org.au> (raw)
In-Reply-To: <hkneh9$djl$1@ger.gmane.org>

Hi Bill.

Bill Davidsen wrote:
> I would hope someone will look at the real problem, though, that LZO
> isn't working properly. I have to assume that either the kernel
> decompress is broken or that the page you have given is invalid, and the
> error lies in the compression.
> 
> It doesn't look as if you are doing something wrong, it looks broken.

I did get hold of Richard Purdie and Nitin Gupta, who were the guys in
the know. We discovered that LZO is expecting decomp_size to be
initialised to the amount of available space when the decompression code
is called, so there was a bug in my testing code. Nitin was talking
about sending a patch to the documentation to make this requirement clearer.

That said, the actual code that TuxOnIce uses does already initialise
the variable to PAGE_SIZE, so it seems that I might just have to run
with the checking code enabled (with this fix) for a while, until the
issue is found.

Regards,

Nigel


  reply	other threads:[~2010-02-08  8:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-03 21:38 LZO irreversible output? Nigel Cunningham
2010-02-03 22:54 ` Rafael J. Wysocki
2010-02-04  4:37   ` Nigel Cunningham
2010-02-07 22:23     ` Bill Davidsen
2010-02-08  8:33       ` Nigel Cunningham [this message]
2010-02-09 17:32         ` [TuxOnIce-devel] " Nix
2010-02-09 20:38           ` Nigel Cunningham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B6FCC47.2030705@crca.org.au \
    --to=ncunningham@crca.org.au \
    --cc=davidsen@tmr.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tuxonice-devel@lists.tuxonice.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox