public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Roel Kluin <roel.kluin@gmail.com>
To: Greg Ungerer <gerg@uclinux.org>,
	uclinux-dev@uclinux.org,
	Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: m68knommu: duplicate _ramvec[vba+CPMVEC_RISCTIMER] assignment in init_IRQ()
Date: Wed, 10 Feb 2010 15:10:17 +0100	[thread overview]
Message-ID: <4B72BE49.70803@gmail.com> (raw)

Hi,

Looking at arch/m68knommu/platform/68360/ints.c I noted two things that
stood out:

1) on line 110:

_ramvec[vba+CPMVEC_RISCTIMER]   = inthandler;  /* reserved */

and 114:

_ramvec[vba+CPMVEC_RISCTIMER]   = inthandler;  /* timer table */

The same definitions are used, and in the first case the comment and
definition do not correspond.

2) while all other definitions are used like this:

_ramvec[vba+CPMVEC_DEF2]   = inthandler;
...
_ramvec[vba+CPMVEC_DEF1]   = inthandler;

This is not true for CPMVEC_RESERVED:

_ramvec[vba+CPMVEC_RESERVED1]   = inthandler;   /* reserved */
...
_ramvec[vba+CPMVEC_RESERVED2]   = inthandler;  /* reserved */

Is this a bug?

Roel

             reply	other threads:[~2010-02-10 14:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-10 14:10 Roel Kluin [this message]
2010-02-12 12:10 ` m68knommu: duplicate _ramvec[vba+CPMVEC_RISCTIMER] assignment in init_IRQ() Greg Ungerer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B72BE49.70803@gmail.com \
    --to=roel.kluin@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=gerg@uclinux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=uclinux-dev@uclinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox