Re: [PATCH 1/1] ftrace - add support for tracing_thresh to function_graph tracer

[Tim Bird <tim.bird@am.sony.com>]

On 02/11/2010 03:10 PM, Steven Rostedt wrote:
> On Wed, 2010-02-10 at 14:52 -0800, Tim Bird wrote:
>>  static struct tracer_opt trace_opts[] = {
>>  	/* Display overruns? (for self-debug purpose) */
>> @@ -53,6 +54,8 @@ static struct tracer_opt trace_opts[] = {
>>  	{ TRACER_OPT(funcgraph-duration, TRACE_GRAPH_PRINT_DURATION) },
>>  	/* Display absolute time of an entry */
>>  	{ TRACER_OPT(funcgraph-abstime, TRACE_GRAPH_PRINT_ABS_TIME) },
>> +	/* Display function name on exit, instead of just closing brace */
>> +	{ TRACER_OPT(funcgraph-exit, TRACE_GRAPH_PRINT_FUNC_EXIT) },
>>  	{ } /* Empty entry */
> 
> I wonder if this should be enabled on start up of the function graph
> tracer if the threshold is set?
> 
> Otherwise people will wonder WTF?

Indeed.  I'm not sure exactly how to do this.

Would it be better to set the option when current_tracer
is set with 'function_graph', and tracing_thresh is non-zero?
Or should I set the option when tracing_thresh is set to
non-zero, and the current_trace is set to 'function_graph'?

Or both?

It wouldn't automatically reset to nofuncgraph-exit
unless I also put some magic in for that.  I'm
pretty sure that disabling it automatically would
lead to unobvious behaviour for the user.

I'll look into how to access the options
from those two points, and see what looks feasible.
 -- Tim

=============================
Tim Bird
Architecture Group Chair, CE Linux Forum
Senior Staff Engineer, Sony Corporation of America
=============================