From: Tilman Schmidt <tilman@imap.cc>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andy Shevchenko <ext-andriy.shevchenko@nokia.com>
Subject: Re: [PATCH 01/12] isdn: remove ishexdigit() in regard to isxdigit()
Date: Fri, 19 Feb 2010 00:36:09 +0100 [thread overview]
Message-ID: <4B7DCEE9.4080208@imap.cc> (raw)
In-Reply-To: <1266519351-3218-2-git-send-email-andy.shevchenko@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1667 bytes --]
Am 18.02.2010 19:55 schrieb Andy Shevchenko:
> From: Andy Shevchenko <ext-andriy.shevchenko@nokia.com>
>
> Samll cleanup in drivers/isdn/gigaset/capi.c where own implementation of
> isxdigit() has been changed to kernel native one.
>
> Signed-off-by: Andy Shevchenko <ext-andriy.shevchenko@nokia.com>
Acked-by: Tilman Schmidt <tilman@imap.cc>
Thanks,
Tilman
> ---
> drivers/isdn/gigaset/capi.c | 16 +---------------
> 1 files changed, 1 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/isdn/gigaset/capi.c b/drivers/isdn/gigaset/capi.c
> index 3f5cd06..83c4e2f 100644
> --- a/drivers/isdn/gigaset/capi.c
> +++ b/drivers/isdn/gigaset/capi.c
> @@ -169,20 +169,6 @@ static inline void ignore_cstruct_param(struct cardstate *cs, _cstruct param,
> }
>
> /*
> - * check for legal hex digit
> - */
> -static inline int ishexdigit(char c)
> -{
> - if (c >= '0' && c <= '9')
> - return 1;
> - if (c >= 'A' && c <= 'F')
> - return 1;
> - if (c >= 'a' && c <= 'f')
> - return 1;
> - return 0;
> -}
> -
> -/*
> * convert hex to binary
> */
> static inline u8 hex2bin(char c)
> @@ -202,7 +188,7 @@ static int encode_ie(char *in, u8 *out, int maxlen)
> {
> int l = 0;
> while (*in) {
> - if (!ishexdigit(in[0]) || !ishexdigit(in[1]) || l >= maxlen)
> + if (!isxdigit(in[0]) || !isxdigit(in[1]) || l >= maxlen)
> return -1;
> out[++l] = (hex2bin(in[0]) << 4) + hex2bin(in[1]);
> in += 2;
--
Tilman Schmidt E-Mail: tilman@imap.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
next prev parent reply other threads:[~2010-02-18 23:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-18 18:55 [PATCH 00/12] Clean up code to use native kernel functions when convert or check hex digits Andy Shevchenko
2010-02-18 18:55 ` [PATCH 01/12] isdn: remove ishexdigit() in regard to isxdigit() Andy Shevchenko
2010-02-18 18:55 ` [PATCH 02/12] audit: use kernel's method to get byte in hex form Andy Shevchenko
2010-02-18 18:55 ` [PATCH 03/12] staging: remove unused methods Andy Shevchenko
2010-02-18 18:55 ` [PATCH 04/12] scsi: ibmmca: use kernel native convertor Andy Shevchenko
2010-02-18 18:55 ` [PATCH 05/12] lib: introduce common method to convert hex digits Andy Shevchenko
2010-02-18 18:55 ` [PATCH 06/12] drivers: net: optimize hex2bin() Andy Shevchenko
2010-02-18 18:55 ` [PATCH 07/12] usb: atm: speedtch: use new hex_to_bin() method Andy Shevchenko
2010-02-18 18:55 ` [PATCH 08/12] net: " Andy Shevchenko
2010-02-18 18:55 ` [PATCH 09/12] drivers: net: use kernel's method to get byte in hex form Andy Shevchenko
2010-02-18 18:55 ` [PATCH 10/12] drivers: net: use new hex_to_bin() method Andy Shevchenko
2010-02-18 18:55 ` [PATCH 11/12] drivers: isdn: " Andy Shevchenko
2010-02-18 18:55 ` [PATCH 12/12] drivers: wireless: use kernel's method to get byte in hex form Andy Shevchenko
2010-02-18 23:55 ` [PATCH 11/12] drivers: isdn: use new hex_to_bin() method Tilman Schmidt
2010-02-19 9:53 ` [PATCHv2] " Andy Shevchenko
2010-02-19 14:53 ` [PATCH 03/12] staging: remove unused methods Greg KH
2010-02-22 20:21 ` [PATCH 02/12] audit: use kernel's method to get byte in hex form Eric Paris
2010-02-22 21:18 ` Andy Shevchenko
2010-02-18 23:36 ` Tilman Schmidt [this message]
2010-02-19 11:41 ` [PATCH 00/12] Clean up code to use native kernel functions when convert or check hex digits Andy Shevchenko
2010-02-19 23:44 ` Tilman Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B7DCEE9.4080208@imap.cc \
--to=tilman@imap.cc \
--cc=andy.shevchenko@gmail.com \
--cc=ext-andriy.shevchenko@nokia.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox