From: Randy Dunlap <rdunlap@xenotime.net>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
Adam Belay <abelay@mit.edu>
Subject: Re: [PATCH v1 2/7] vsprintf: clarify comments for printf_spec flags
Date: Fri, 19 Feb 2010 10:06:44 -0800 [thread overview]
Message-ID: <4B7ED334.5000603@xenotime.net> (raw)
In-Reply-To: <20100219175828.9199.12642.stgit@bob.kio>
On 02/19/10 09:58, Bjorn Helgaas wrote:
>
> Add clues about what the SMALL and SPECIAL flags do.
>
> Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
> ---
>
> lib/vsprintf.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>
> diff --git a/lib/vsprintf.c b/lib/vsprintf.c
> index 3b8aeec..212d047 100644
> --- a/lib/vsprintf.c
> +++ b/lib/vsprintf.c
> @@ -381,8 +381,8 @@ static noinline char *put_dec(char *buf, unsigned long long num)
> #define PLUS 4 /* show plus */
> #define SPACE 8 /* space if plus */
> #define LEFT 16 /* left justified */
> -#define SMALL 32 /* Must be 32 == 0x20 */
> -#define SPECIAL 64 /* 0x */
> +#define SMALL 32 /* use lowercase in hex (must be 32 == 0x20) */
> +#define SPECIAL 64 /* prefix hex with "0x", octal with "0 */
might as well do: octal with "0" */
>
> enum format_type {
> FORMAT_TYPE_NONE, /* Just a string part */
--
~Randy
next prev parent reply other threads:[~2010-02-19 18:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-19 17:58 [PATCH v1 0/7] resource, PNPACPI: add bus number and window support Bjorn Helgaas
2010-02-19 17:58 ` [PATCH v1 1/7] resource: expand IORESOURCE_TYPE_BITS to make room for bus resource type Bjorn Helgaas
2010-02-19 17:58 ` [PATCH v1 2/7] vsprintf: clarify comments for printf_spec flags Bjorn Helgaas
2010-02-19 18:06 ` Randy Dunlap [this message]
2010-02-19 17:58 ` [PATCH v1 3/7] vsprintf: move %pR resource printf_specs off the stack Bjorn Helgaas
2010-02-19 17:58 ` [PATCH v1 4/7] resource: add bus number support Bjorn Helgaas
2010-02-19 17:58 ` [PATCH v1 5/7] resource: add window support Bjorn Helgaas
2010-02-19 17:58 ` [PATCH v1 6/7] PNPACPI: " Bjorn Helgaas
2010-02-19 17:58 ` [PATCH v1 7/7] PNPACPI: add bus number support Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B7ED334.5000603@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=abelay@mit.edu \
--cc=bjorn.helgaas@hp.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox