* [PATCH] ARM: misplaced parentheses?
@ 2010-02-20 0:19 Roel Kluin
2010-02-23 15:03 ` Linus Walleij
0 siblings, 1 reply; 3+ messages in thread
From: Roel Kluin @ 2010-02-20 0:19 UTC (permalink / raw)
To: Andrew Morton, LKML, linus.walleij
The parentheses appear misplaced.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
Correct?
diff --git a/arch/arm/mach-u300/gpio.c b/arch/arm/mach-u300/gpio.c
index 0b35826..5f61fd4 100644
--- a/arch/arm/mach-u300/gpio.c
+++ b/arch/arm/mach-u300/gpio.c
@@ -546,7 +546,7 @@ static void gpio_set_initial_values(void)
for (i = 0; i < U300_GPIO_MAX; i++) {
val = 0;
for (j = 0; j < 8; j++)
- val |= (u32)((u300_gpio_config[i][j].pull_up == DISABLE_PULL_UP)) << j;
+ val |= (u32)((u300_gpio_config[i][j].pull_up == DISABLE_PULL_UP) << j);
local_irq_save(flags);
writel(val, virtbase + U300_GPIO_PXPER + i * U300_GPIO_PORTX_SPACING);
local_irq_restore(flags);
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH] ARM: misplaced parentheses?
2010-02-20 0:19 [PATCH] ARM: misplaced parentheses? Roel Kluin
@ 2010-02-23 15:03 ` Linus Walleij
2010-02-23 22:42 ` roel kluin
0 siblings, 1 reply; 3+ messages in thread
From: Linus Walleij @ 2010-02-23 15:03 UTC (permalink / raw)
To: Roel Kluin, Andrew Morton, LKML; +Cc: Russell King - ARM Linux
[Roel]
> The parentheses appear misplaced.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> Correct?
>
> diff --git a/arch/arm/mach-u300/gpio.c b/arch/arm/mach-u300/gpio.c
> index 0b35826..5f61fd4 100644
> --- a/arch/arm/mach-u300/gpio.c
> +++ b/arch/arm/mach-u300/gpio.c
> @@ -546,7 +546,7 @@ static void gpio_set_initial_values(void)
> for (i = 0; i < U300_GPIO_MAX; i++) {
> val = 0;
> for (j = 0; j < 8; j++)
> - val |=
> (u32)((u300_gpio_config[i][j].pull_up == DISABLE_PULL_UP)) << j;
> + val |=
> (u32)((u300_gpio_config[i][j].pull_up == DISABLE_PULL_UP) << j);
> local_irq_save(flags);
> writel(val, virtbase + U300_GPIO_PXPER + i *
> U300_GPIO_PORTX_SPACING);
> local_irq_restore(flags);
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
BTW this should go in through Russells patch tracker, can you
put it there?
http://www.arm.linux.org.uk/developer/patches/
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-02-23 22:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-20 0:19 [PATCH] ARM: misplaced parentheses? Roel Kluin
2010-02-23 15:03 ` Linus Walleij
2010-02-23 22:42 ` roel kluin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox