* [PATCH] m68k,m68knommu: missing asterisk?
@ 2010-02-20 0:37 Roel Kluin
2010-02-23 6:13 ` Geert Uytterhoeven
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2010-02-20 0:37 UTC (permalink / raw)
To: Andrew Morton, LKML, geert
An asterisk was missing.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
Correct?
arch/m68k/include/asm/apollohw.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/m68k/include/asm/apollohw.h b/arch/m68k/include/asm/apollohw.h
index a1373b9..87e0cc4 100644
--- a/arch/m68k/include/asm/apollohw.h
+++ b/arch/m68k/include/asm/apollohw.h
@@ -94,7 +94,7 @@ extern u_long timer_physaddr;
#define sio01 ((*(volatile struct SCN2681 *)(IO_BASE + sio01_physaddr)))
#define sio23 ((*(volatile struct SCN2681 *)(IO_BASE + sio23_physaddr)))
-#define rtc (((volatile struct mc146818 *)(IO_BASE + rtc_physaddr)))
+#define rtc ((*(volatile struct mc146818 *)(IO_BASE + rtc_physaddr)))
#define cpuctrl (*(volatile unsigned int *)(IO_BASE + cpuctrl_physaddr))
#define pica (IO_BASE + pica_physaddr)
#define picb (IO_BASE + picb_physaddr)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] m68k,m68knommu: missing asterisk?
2010-02-20 0:37 [PATCH] m68k,m68knommu: missing asterisk? Roel Kluin
@ 2010-02-23 6:13 ` Geert Uytterhoeven
0 siblings, 0 replies; 2+ messages in thread
From: Geert Uytterhoeven @ 2010-02-23 6:13 UTC (permalink / raw)
To: Roel Kluin
Cc: Andrew Morton, LKML, Peter 'p2' De Schrijver, Linux/m68k
On Sat, Feb 20, 2010 at 01:37, Roel Kluin <roel.kluin@gmail.com> wrote:
> An asterisk was missing.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> Correct?
No, see arch/m68k/apollo/config.c:dn_dummy_hwclk().
Andrew: please dequeue.
> arch/m68k/include/asm/apollohw.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/m68k/include/asm/apollohw.h b/arch/m68k/include/asm/apollohw.h
> index a1373b9..87e0cc4 100644
> --- a/arch/m68k/include/asm/apollohw.h
> +++ b/arch/m68k/include/asm/apollohw.h
> @@ -94,7 +94,7 @@ extern u_long timer_physaddr;
>
> #define sio01 ((*(volatile struct SCN2681 *)(IO_BASE + sio01_physaddr)))
> #define sio23 ((*(volatile struct SCN2681 *)(IO_BASE + sio23_physaddr)))
> -#define rtc (((volatile struct mc146818 *)(IO_BASE + rtc_physaddr)))
> +#define rtc ((*(volatile struct mc146818 *)(IO_BASE + rtc_physaddr)))
> #define cpuctrl (*(volatile unsigned int *)(IO_BASE + cpuctrl_physaddr))
> #define pica (IO_BASE + pica_physaddr)
> #define picb (IO_BASE + picb_physaddr)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-02-23 6:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-20 0:37 [PATCH] m68k,m68knommu: missing asterisk? Roel Kluin
2010-02-23 6:13 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox