linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: "Cengiz Günay" <cgunay@EMORY.EDU>
Cc: Robert Hancock <hancockrwd@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>
Subject: Re: sata_nv times out for BD-ROM iHOS104-08
Date: Sun, 21 Feb 2010 10:01:27 +0900	[thread overview]
Message-ID: <4B8085E7.5000501@kernel.org> (raw)
In-Reply-To: <d2d378041002201111g7af41a3dpdb2fa300a65d56bf@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 452 bytes --]

On 02/21/2010 04:11 AM, Cengiz Günay wrote:
>> Does the attached patch make any difference?
> 
> Not that I can tell. I still get an infinite loop of ata4 errors. I
> attached a full dmesg output with the patch. Note that I have both the
> patches disable-clear-ua and drain-from-atapi-pio-bytes applied at the
> same time.

Hmmm... So, DRQ gets cleared?  That's strange.  When then the 18 extra
bytes happen?  Can you please try this one?

-- 
tejun

[-- Attachment #2: swncq-polling-pio.patch --]
[-- Type: text/x-patch, Size: 448 bytes --]

diff --git a/drivers/ata/sata_nv.c b/drivers/ata/sata_nv.c
index 0c82d33..ae63b0b 100644
--- a/drivers/ata/sata_nv.c
+++ b/drivers/ata/sata_nv.c
@@ -585,7 +585,7 @@ static const struct ata_port_info nv_port_info[] = {
 	/* SWNCQ */
 	{
 		.flags	        = ATA_FLAG_SATA | ATA_FLAG_NO_LEGACY |
-				  ATA_FLAG_NCQ,
+				  ATA_FLAG_NCQ | ATA_FLAG_PIO_POLLING,
 		.pio_mask	= NV_PIO_MASK,
 		.mwdma_mask	= NV_MWDMA_MASK,
 		.udma_mask	= NV_UDMA_MASK,

  reply	other threads:[~2010-02-21  0:52 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-22 16:07 sata_nv times out for BD-ROM iHOS104-08 Cengiz Gunay
2009-12-23  7:38 ` Tejun Heo
     [not found]   ` <d2d378040912232302u4b550dap687fcadced237935@mail.gmail.com>
2009-12-24  7:25     ` Tejun Heo
2010-01-16 21:34       ` Cengiz Günay
2010-01-17 15:28         ` Ozan Çağlayan
2010-01-19  9:05           ` Tejun Heo
2010-01-19  9:34             ` Ozan Çağlayan
2010-01-20  2:13         ` Tejun Heo
2010-01-20  2:59           ` Robert Hancock
2010-01-22 14:11             ` Cengiz Günay
2010-01-23  3:45               ` Tejun Heo
2010-01-23 21:39                 ` Cengiz Günay
     [not found]                   ` <4B67A149.10406@kernel.org>
2010-02-17 16:14                     ` Cengiz Günay
2010-02-18  1:50                       ` Tejun Heo
2010-02-20 19:11                         ` Cengiz Günay
2010-02-21  1:01                           ` Tejun Heo [this message]
2010-02-21 21:28                             ` Cengiz Günay
2010-02-23  2:38                               ` Tejun Heo
2010-02-28 17:24                                 ` Cengiz Günay
2010-03-02 11:48                                   ` Tejun Heo
2010-03-08 19:17                                     ` Cengiz Günay
2010-03-08 23:46                                       ` Robert Hancock
2010-03-09  1:21                                       ` Tejun Heo
2010-03-09  5:18                                         ` Cengiz Günay
2010-05-25 19:34                                           ` Tejun Heo
  -- strict thread matches above, loose matches on Subject: below --
2010-01-17  4:54 Gregory Moyer
2010-01-21  3:15 Gregory Moyer
2010-06-03 17:40 Gregory Moyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B8085E7.5000501@kernel.org \
    --to=tj@kernel.org \
    --cc=cgunay@EMORY.EDU \
    --cc=hancockrwd@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).