From: Jim Dog <jimdog@aktivix.org>
To: "Gábor Stefanik" <netrolller.3d@gmail.com>
Cc: jimdog@northern-indymedia.org, gregkh@suse.de, jmm@debian.org,
mithlesh@linsyssoft.com, richard@rsk.demon.co.uk,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: wlan-ng: Fix 80 character limit warnings Fixed 2 warnings identified by the checkpatch.pl tool which occured due to two lines of code going over the 80 character limit. Fixed by wrapping the lines. Signed-off-by: Jim Dog <jimdog@
Date: Sun, 21 Feb 2010 15:46:23 +0000 [thread overview]
Message-ID: <4B81554F.40407@aktivix.org> (raw)
In-Reply-To: <69e28c911002210706k1a5ae686r76df74a743dcce1c@mail.gmail.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Not sure, guess that's why it's commented out. I just wrapped it so it
fitted in 80 chars.
JD
Gábor Stefanik wrote:
> On Sun, Feb 21, 2010 at 4:03 PM, <jimdog@northern-indymedia.org> wrote:
>> From: Jim Dog <jimdog@northern-indymedia.org>
>>
>> ---
>> drivers/staging/wlan-ng/prism2usb.c | 9 ++++++---
>> 1 files changed, 6 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/staging/wlan-ng/prism2usb.c b/drivers/staging/wlan-ng/prism2usb.c
>> index 9dde68b..b55930c 100644
>> --- a/drivers/staging/wlan-ng/prism2usb.c
>> +++ b/drivers/staging/wlan-ng/prism2usb.c
>> @@ -24,8 +24,9 @@ static struct usb_device_id usb_prism_tbl[] = {
>> (0x066b, 0x2213, "Linksys WUSB12v1.1 11Mbps WLAN USB Adapter")},
>> {PRISM_USB_DEVICE
>> (0x067c, 0x1022, "Siemens SpeedStream 1022 11Mbps WLAN USB Adapter")},
>> - {PRISM_USB_DEVICE(0x049f, 0x0033,
>> - "Compaq/Intel W100 PRO/Wireless 11Mbps multiport WLAN Adapter")},
>> + {PRISM_USB_DEVICE
>> + (0x049f, 0x0033,
>> + "Compaq/Intel W100 PRO/Wireless 11Mbps multiport WLAN Adapter")},
>> {PRISM_USB_DEVICE
>> (0x0411, 0x0016, "Melco WLI-USB-S11 11Mbps WLAN Adapter")},
>> {PRISM_USB_DEVICE
>> @@ -55,7 +56,9 @@ static struct usb_device_id usb_prism_tbl[] = {
>> (0x04f1, 0x3009, "JVC MP-XP7250 Builtin USB WLAN Adapter")},
>> {PRISM_USB_DEVICE(0x0846, 0x4110, "NetGear MA111")},
>> {PRISM_USB_DEVICE(0x03f3, 0x0020, "Adaptec AWN-8020 USB WLAN Adapter")},
>> -/* {PRISM_USB_DEVICE(0x0ace, 0x1201, "ZyDAS ZD1201 Wireless USB Adapter")}, */
>> +/*
>> + {PRISM_USB_DEVICE(0x0ace, 0x1201, "ZyDAS ZD1201 Wireless USB Adapter")},
>> +*/
>
> Why is this even included? We do have support for this in zd1201, and
> I'm pretty sure wlan-ng doesn't actually handle it.
>
>> {PRISM_USB_DEVICE(0x2821, 0x3300, "ASUS-WL140 Wireless USB Adapter")},
>> {PRISM_USB_DEVICE(0x2001, 0x3700, "DWL-122 Wireless USB Adapter")},
>> {PRISM_USB_DEVICE
>> --
>> 1.6.3.3
>>
>> _______________________________________________
>> devel mailing list
>> devel@linuxdriverproject.org
>> http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
>>
>
>
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkuBVUAACgkQjI3ttaQQxva7ywCgtB2/cbd+Tz+4WvvlyIGKwiFq
o6kAnjIu9lCZeIEb374pfZRoEU3G9oQx
=TKK4
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2010-02-21 16:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-21 15:06 [PATCH] Staging: wlan-ng: Fix 80 character limit warnings Fixed 2 warnings identified by the checkpatch.pl tool which occured due to two lines of code going over the 80 character limit. Fixed by wrapping the lines. Signed-off-by: Jim Dog <jimdog@ Gábor Stefanik
2010-02-21 15:46 ` Jim Dog [this message]
2010-02-23 14:35 ` Richard Kennedy
-- strict thread matches above, loose matches on Subject: below --
2010-02-23 15:37 JimDog
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B81554F.40407@aktivix.org \
--to=jimdog@aktivix.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=jimdog@northern-indymedia.org \
--cc=jmm@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mithlesh@linsyssoft.com \
--cc=netrolller.3d@gmail.com \
--cc=richard@rsk.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox