public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Jaswinder Singh Rajput <jaswinder@kernel.org>
Cc: Joel Becker <joel.becker@oracle.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] Re: How to disable configfs_example modules
Date: Sun, 21 Feb 2010 10:09:16 -0800	[thread overview]
Message-ID: <4B8176CC.40506@oracle.com> (raw)
In-Reply-To: <1266765484.2192.5.camel@localhost>

On 02/21/10 07:18, Jaswinder Singh Rajput wrote:
> Hello Randy,

Hi Jaswinder,

> I am trying to build no modules but unfortunately I am getting 3 modules
> with http://userweb.kernel.org/~jaswinder/Corei7/config-i7-64.txt :
> 
>   INSTALL Documentation/filesystems/configfs/configfs_example_explicit.ko
>   INSTALL Documentation/filesystems/configfs/configfs_example_macros.ko
>   INSTALL drivers/scsi/scsi_wait_scan.ko
> 
> How can I get rid of configfs_example modules.
> 
> What is the magic in 'ifneq ($(CONFIG_CONFIGFS_FS),)' :

That just says: if CONFIG_CONFIGFS_FS neq empty_string
  [where the empty_string is between the ",)"]

> Documentation/filesystems/configfs/Makefile :
> ifneq ($(CONFIG_CONFIGFS_FS),)
> obj-m += configfs_example_explicit.o configfs_example_macros.o
> endif


I think that this patch will do it.  Please let me know if it
does not work.

---
From: Randy Dunlap <randy.dunlap@oracle.com>

Documentation/ source files that are kernel modules should
not be built when CONFIG_MODULES is not enabled, so change
the Makefile to enforce that.

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 Documentation/filesystems/configfs/Makefile |    2 ++
 1 file changed, 2 insertions(+)

--- lnx-2633-rc8.orig/Documentation/filesystems/configfs/Makefile
+++ lnx-2633-rc8/Documentation/filesystems/configfs/Makefile
@@ -1,3 +1,5 @@
+ifeq ($(CONFIG_MODULES),1)
 ifneq ($(CONFIG_CONFIGFS_FS),)
 obj-m += configfs_example_explicit.o configfs_example_macros.o
 endif
+endif

  reply	other threads:[~2010-02-21 18:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-21 15:18 How to disable configfs_example modules Jaswinder Singh Rajput
2010-02-21 18:09 ` Randy Dunlap [this message]
2010-02-21 18:44   ` [PATCH] " Jaswinder Singh Rajput

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B8176CC.40506@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=jaswinder@kernel.org \
    --cc=joel.becker@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox