public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* How to disable configfs_example modules
@ 2010-02-21 15:18 Jaswinder Singh Rajput
  2010-02-21 18:09 ` [PATCH] " Randy Dunlap
  0 siblings, 1 reply; 3+ messages in thread
From: Jaswinder Singh Rajput @ 2010-02-21 15:18 UTC (permalink / raw)
  To: Randy Dunlap, Joel Becker, LKML

Hello Randy,

I am trying to build no modules but unfortunately I am getting 3 modules
with http://userweb.kernel.org/~jaswinder/Corei7/config-i7-64.txt :

  INSTALL Documentation/filesystems/configfs/configfs_example_explicit.ko
  INSTALL Documentation/filesystems/configfs/configfs_example_macros.ko
  INSTALL drivers/scsi/scsi_wait_scan.ko

How can I get rid of configfs_example modules.

What is the magic in 'ifneq ($(CONFIG_CONFIGFS_FS),)' :

Documentation/filesystems/configfs/Makefile :
ifneq ($(CONFIG_CONFIGFS_FS),)
obj-m += configfs_example_explicit.o configfs_example_macros.o
endif

Thanks,
--
Jaswinder Singh.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] Re: How to disable configfs_example modules
  2010-02-21 15:18 How to disable configfs_example modules Jaswinder Singh Rajput
@ 2010-02-21 18:09 ` Randy Dunlap
  2010-02-21 18:44   ` Jaswinder Singh Rajput
  0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2010-02-21 18:09 UTC (permalink / raw)
  To: Jaswinder Singh Rajput; +Cc: Joel Becker, LKML

On 02/21/10 07:18, Jaswinder Singh Rajput wrote:
> Hello Randy,

Hi Jaswinder,

> I am trying to build no modules but unfortunately I am getting 3 modules
> with http://userweb.kernel.org/~jaswinder/Corei7/config-i7-64.txt :
> 
>   INSTALL Documentation/filesystems/configfs/configfs_example_explicit.ko
>   INSTALL Documentation/filesystems/configfs/configfs_example_macros.ko
>   INSTALL drivers/scsi/scsi_wait_scan.ko
> 
> How can I get rid of configfs_example modules.
> 
> What is the magic in 'ifneq ($(CONFIG_CONFIGFS_FS),)' :

That just says: if CONFIG_CONFIGFS_FS neq empty_string
  [where the empty_string is between the ",)"]

> Documentation/filesystems/configfs/Makefile :
> ifneq ($(CONFIG_CONFIGFS_FS),)
> obj-m += configfs_example_explicit.o configfs_example_macros.o
> endif


I think that this patch will do it.  Please let me know if it
does not work.

---
From: Randy Dunlap <randy.dunlap@oracle.com>

Documentation/ source files that are kernel modules should
not be built when CONFIG_MODULES is not enabled, so change
the Makefile to enforce that.

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 Documentation/filesystems/configfs/Makefile |    2 ++
 1 file changed, 2 insertions(+)

--- lnx-2633-rc8.orig/Documentation/filesystems/configfs/Makefile
+++ lnx-2633-rc8/Documentation/filesystems/configfs/Makefile
@@ -1,3 +1,5 @@
+ifeq ($(CONFIG_MODULES),1)
 ifneq ($(CONFIG_CONFIGFS_FS),)
 obj-m += configfs_example_explicit.o configfs_example_macros.o
 endif
+endif

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Re: How to disable configfs_example modules
  2010-02-21 18:09 ` [PATCH] " Randy Dunlap
@ 2010-02-21 18:44   ` Jaswinder Singh Rajput
  0 siblings, 0 replies; 3+ messages in thread
From: Jaswinder Singh Rajput @ 2010-02-21 18:44 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: Jaswinder Singh Rajput, Joel Becker, LKML

Hello Randy,

On Sun, Feb 21, 2010 at 11:39 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote:
> On 02/21/10 07:18, Jaswinder Singh Rajput wrote:
>> I am trying to build no modules but unfortunately I am getting 3 modules
>> with http://userweb.kernel.org/~jaswinder/Corei7/config-i7-64.txt :
>>
>>   INSTALL Documentation/filesystems/configfs/configfs_example_explicit.ko
>>   INSTALL Documentation/filesystems/configfs/configfs_example_macros.ko
>>   INSTALL drivers/scsi/scsi_wait_scan.ko
>>
>> How can I get rid of configfs_example modules.
>>
>> What is the magic in 'ifneq ($(CONFIG_CONFIGFS_FS),)' :
>
> That just says: if CONFIG_CONFIGFS_FS neq empty_string
>  [where the empty_string is between the ",)"]
>

Thanks for the explanation by disabling CONFIG_CONFIGFS_FS, I get rid
of configfs_example modules. Patch is not required.

Thanks for your help,
--
Jaswinder Singh.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-02-21 18:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-21 15:18 How to disable configfs_example modules Jaswinder Singh Rajput
2010-02-21 18:09 ` [PATCH] " Randy Dunlap
2010-02-21 18:44   ` Jaswinder Singh Rajput

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox