From: John Johansen <john.johansen@canonical.com>
To: john.johansen@canonical.com
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] Fix __d_path for lazy unmounts
Date: Mon, 22 Feb 2010 09:24:45 -0800 [thread overview]
Message-ID: <4B82BDDD.9020407@canonical.com> (raw)
In-Reply-To: <1266668858-15253-1-git-send-email-john.johansen@canonical.com>
john.johansen@canonical.com wrote:
> From: John Johansen <john.johansen@canonical.com>
>
> When __d_path() hits a lazily unmounted mount point, it tries to prepend
> the name of the lazily unmounted dentry to the path name. It gets this wrong,
> and also overwrites the slash that separates the name from the following
> pathname component. This patch fixes that; if a process was in directory
> /foo/bar and /foo got lazily unmounted, the old result was ``foobar'' (note the
> missing slash), while the new result with this patch is ``/foo/bar''.
>
It seems I left out the basic test for this. From a shell you can do
> mkdir /tmp/foo
> sudo mount --bind /home/jj /tmp/foo #substitute /home/jj as you wish
> cd /tmp/foo/bar # assumes /home/jj/bar exists
> /bin/pwd
/tmp/foo/bar
> sudo umount -l /tmp/foo
> /bin/pwd
jjbar
> > cd ..
> > /bin/pwd
jj
next prev parent reply other threads:[~2010-02-22 17:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-20 12:27 [PATCH] Fix __d_path for lazy unmounts john.johansen
2010-02-22 17:24 ` John Johansen [this message]
2010-02-22 17:38 ` Serge E. Hallyn
2010-02-23 0:17 ` Andrew Morton
2010-02-23 1:04 ` Serge E. Hallyn
2010-02-24 0:12 ` [Patch 0/1] Fix __d_path for lazy unmounts v2 john.johansen
2010-02-24 0:12 ` [PATCH] Fix __d_path for lazy unmounts john.johansen
2010-02-23 1:56 ` John Johansen
2010-02-26 12:07 ` Miklos Szeredi
2010-02-26 17:07 ` John Johansen
2010-03-01 10:05 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B82BDDD.9020407@canonical.com \
--to=john.johansen@canonical.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox