From: Jeff Garzik <jeff@garzik.org>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [git patch] atang tree: enhanced SSD detection
Date: Tue, 23 Feb 2010 01:08:21 -0500 [thread overview]
Message-ID: <4B8370D5.1070302@garzik.org> (raw)
In-Reply-To: <201002211841.24936.bzolnier@gmail.com>
On 02/21/2010 12:41 PM, Bartlomiej Zolnierkiewicz wrote:
> DISCLAIMER: the fact of getting patches merged into atang tree means
> that from now on they will be getting updates for changes happening
> in atang tree and it should not be treated as an indication regarding
> decisions taken by 'upstream' kernel trees
>
>
> Improve SSD detection so block layer optimizations can be applied
> to many more SSD devices.
>
>
> The following changes since commit 17c619273d412ed7b6120e448f87b2329457fc90:
> Bartlomiej Zolnierkiewicz (1):
> pata_oldpiix: enable parallel scan
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/bart/misc.git atang-v4.7
>
> Bartlomiej Zolnierkiewicz (1):
> libata: enhanced SSD detection
>
> drivers/ata/libata-core.c | 3 +++
> drivers/ata/libata-scsi.c | 18 ++++++++++--------
> include/linux/libata.h | 1 +
> 3 files changed, 14 insertions(+), 8 deletions(-)
>
>
> commit ded92e0d01fbb7f27bec7a35606847a2547e95e0
> Author: Bartlomiej Zolnierkiewicz<bzolnier@gmail.com>
> Date: Sun Feb 21 18:31:18 2010 +0100
>
> libata: enhanced SSD detection
>
> Many SSD devices predate or just don't implement non-rotational
> media type advertisement through the word 217 of the id block so
> check also the product id for 'SSD' substring to automatically
> detect SSD devices and apply relevant block layer optimizations.
>
> This is based on earlier Jeff Garzik's patch from April 2009:
> http://lkml.org/lkml/2009/4/7/495
>
> While at it:
> - cleanup ata_scsi_dev_config() a bit
>
> Tested with ASUS-PHISON SSD devices found in Asus Eee 901.
>
> Cc: Jeff Garzik<jeff@garzik.org>
> Signed-off-by: Bartlomiej Zolnierkiewicz<bzolnier@gmail.com>
Yes, I agree we need something like this. I will review for atang
dependencies, and then make sure it gets applied to upstream.
The previous discussion of this approach concluded weakly with "poor
heuristic", but a better approach did not materialize.
One question, though: why did you drop ata_id_is_ssd() test?
Jeff
next prev parent reply other threads:[~2010-02-23 6:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-21 17:41 [git patch] atang tree: enhanced SSD detection Bartlomiej Zolnierkiewicz
2010-02-23 6:08 ` Jeff Garzik [this message]
2010-02-23 12:13 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B8370D5.1070302@garzik.org \
--to=jeff@garzik.org \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox