From: Tejun Heo <htejun@gmail.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Samu Onkalo <samu.p.onkalo@nokia.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] workqueues: microoptimize set_wq_data()
Date: Thu, 25 Feb 2010 19:27:46 +0900 [thread overview]
Message-ID: <4B8650A2.9060803@gmail.com> (raw)
In-Reply-To: <4B85EA24.5020409@kernel.org>
Hello, again.
On 02/25/2010 12:10 PM, Tejun Heo wrote:
>> @@ -220,12 +220,9 @@ struct cpu_workqueue_struct *wq_per_cpu(
>> static inline void set_wq_data(struct work_struct *work,
>> struct cpu_workqueue_struct *cwq)
>> {
>> - unsigned long new;
>> -
>> - BUG_ON(!work_pending(work));
>> -
>> - new = (unsigned long) cwq | (1UL << WORK_STRUCT_PENDING);
>> + unsigned long new = (unsigned long)cwq;
>> new |= WORK_STRUCT_FLAG_MASK & *work_data_bits(work);
>> + BUG_ON(!(new & (1UL << WORK_STRUCT_PENDING)));
>> atomic_long_set(&work->data, new);
>
> Will apply under cmwq patches for the next merge window.
Turns out I already have a patch which kills the second
work_data_bits() dereferencing in the series. The first one is now in
the cmwq series which is about to be posted again.
Thanks.
--
tejun
next prev parent reply other threads:[~2010-02-25 10:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-24 20:20 [PATCH 2/3] workqueues: microoptimize set_wq_data() Oleg Nesterov
2010-02-25 3:10 ` Tejun Heo
2010-02-25 10:27 ` Tejun Heo [this message]
2010-02-25 13:55 ` Oleg Nesterov
2010-02-25 15:16 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B8650A2.9060803@gmail.com \
--to=htejun@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=samu.p.onkalo@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox