From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933814Ab0BZKaw (ORCPT ); Fri, 26 Feb 2010 05:30:52 -0500 Received: from mx1.redhat.com ([209.132.183.28]:3626 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933446Ab0BZKav (ORCPT ); Fri, 26 Feb 2010 05:30:51 -0500 Message-ID: <4B87A2D0.2040605@redhat.com> Date: Fri, 26 Feb 2010 12:30:40 +0200 From: Avi Kivity User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.7) Gecko/20100120 Fedora/3.0.1-1.fc12 Thunderbird/3.0.1 MIME-Version: 1.0 To: Joerg Roedel CC: Marcelo Tosatti , Alexander Graf , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/5] KVM: SVM: Use svm_msrpm_offset in nested_svm_exit_handled_msr References: <1267118149-15737-1-git-send-email-joerg.roedel@amd.com> <1267118149-15737-4-git-send-email-joerg.roedel@amd.com> In-Reply-To: <1267118149-15737-4-git-send-email-joerg.roedel@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/25/2010 07:15 PM, Joerg Roedel wrote: > There is a generic function now to calculate msrpm offsets. > Use that function in nested_svm_exit_handled_msr() remove > the duplicate logic. > > Hm, if the function would also calculate the mask, then it would be useful for set_msr_interception() as well. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.