From: Yinghai Lu <yinghai@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [git pull] PCI changes for 2.6.34 - pci rom rom fail list
Date: Sun, 28 Feb 2010 15:49:39 -0800 [thread overview]
Message-ID: <4B8B0113.1020103@kernel.org> (raw)
In-Reply-To: <4B8AF121.2060106@kernel.org>
please check
[PATCH] pci: don't reassign to ROM res if it is not going to be enabled
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
---
drivers/pci/setup-bus.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
Index: linux-2.6/drivers/pci/setup-bus.c
===================================================================
--- linux-2.6.orig/drivers/pci/setup-bus.c
+++ linux-2.6/drivers/pci/setup-bus.c
@@ -101,9 +101,17 @@ static void __assign_resources_sorted(st
for (list = head->next; list;) {
res = list->res;
idx = res - &list->dev->resource[0];
+
if (pci_assign_resource(list->dev, idx)) {
- if (fail_head && !pci_is_root_bus(list->dev->bus))
- add_to_failed_list(fail_head, list->dev, res);
+ if (fail_head && !pci_is_root_bus(list->dev->bus)) {
+ /*
+ * if the failed res is for ROM BAR, and it will
+ * be enabled later, don't add it to the list
+ */
+ if (!((idx == PCI_ROM_RESOURCE) &&
+ (!(res->flags & IORESOURCE_ROM_ENABLE))))
+ add_to_failed_list(fail_head, list->dev, res);
+ }
res->start = 0;
res->end = 0;
res->flags = 0;
next prev parent reply other threads:[~2010-02-28 23:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-26 17:39 [git pull] PCI changes for 2.6.34 Jesse Barnes
2010-02-28 20:34 ` Linus Torvalds
2010-02-28 20:46 ` Linus Torvalds
2010-02-28 21:11 ` Yinghai
2010-02-28 21:19 ` Linus Torvalds
2010-02-28 22:41 ` Yinghai Lu
2010-02-28 23:49 ` Yinghai Lu [this message]
2010-03-01 6:28 ` [git pull] PCI changes for 2.6.34 - pci rom rom fail list Jesse Barnes
2010-03-01 16:05 ` Linus Torvalds
2010-03-01 16:35 ` Jesse Barnes
2010-03-01 17:38 ` Jesse Barnes
2010-02-28 23:51 ` [git pull] PCI changes for 2.6.34 -- pci_try_num Yinghai Lu
2010-03-01 1:16 ` [git pull] PCI changes for 2.6.34 Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B8B0113.1020103@kernel.org \
--to=yinghai@kernel.org \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox