* [PATCH] drm: fix char constant (sparse warning)
@ 2010-02-24 22:27 Randy Dunlap
2010-03-01 6:01 ` Dave Airlie
0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2010-02-24 22:27 UTC (permalink / raw)
To: lkml; +Cc: David Airlie
From: Randy Dunlap <randy.dunlap@oracle.com>
Fix radeon/atombios.h sparse warning (24 times):
drivers/gpu/drm/radeon/atombios.h:4091:63: error: Bad character constant
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: David Airlie <airlied@linux.ie>
---
drivers/gpu/drm/radeon/atombios.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-2.6.33-rc8.orig/drivers/gpu/drm/radeon/atombios.h
+++ linux-2.6.33-rc8/drivers/gpu/drm/radeon/atombios.h
@@ -4088,7 +4088,7 @@ typedef struct _SW_I2C_IO_DATA_PARAMETER
#define SW_I2C_CNTL_WRITE1BIT 6
/* ==============================VESA definition Portion=============================== */
-#define VESA_OEM_PRODUCT_REV '01.00'
+#define VESA_OEM_PRODUCT_REV "01.00"
#define VESA_MODE_ATTRIBUTE_MODE_SUPPORT 0xBB /* refer to VBE spec p.32, no TTY support */
#define VESA_MODE_WIN_ATTRIBUTE 7
#define VESA_WIN_SIZE 64
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm: fix char constant (sparse warning)
2010-02-24 22:27 [PATCH] drm: fix char constant (sparse warning) Randy Dunlap
@ 2010-03-01 6:01 ` Dave Airlie
2010-03-01 17:06 ` Alex Deucher
0 siblings, 1 reply; 4+ messages in thread
From: Dave Airlie @ 2010-03-01 6:01 UTC (permalink / raw)
To: Randy Dunlap; +Cc: lkml, David Airlie, Alex Deucher
On Thu, Feb 25, 2010 at 8:27 AM, Randy Dunlap <randy.dunlap@oracle.com> wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Fix radeon/atombios.h sparse warning (24 times):
>
> drivers/gpu/drm/radeon/atombios.h:4091:63: error: Bad character constant
We get this file from AMD pretty much as-is and I hate deviating it as it
causes merge issues. Alex any change you can get this fixed upstream?
Dave.
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: David Airlie <airlied@linux.ie>
> ---
> drivers/gpu/drm/radeon/atombios.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-2.6.33-rc8.orig/drivers/gpu/drm/radeon/atombios.h
> +++ linux-2.6.33-rc8/drivers/gpu/drm/radeon/atombios.h
> @@ -4088,7 +4088,7 @@ typedef struct _SW_I2C_IO_DATA_PARAMETER
> #define SW_I2C_CNTL_WRITE1BIT 6
>
> /* ==============================VESA definition Portion=============================== */
> -#define VESA_OEM_PRODUCT_REV '01.00'
> +#define VESA_OEM_PRODUCT_REV "01.00"
> #define VESA_MODE_ATTRIBUTE_MODE_SUPPORT 0xBB /* refer to VBE spec p.32, no TTY support */
> #define VESA_MODE_WIN_ATTRIBUTE 7
> #define VESA_WIN_SIZE 64
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm: fix char constant (sparse warning)
2010-03-01 6:01 ` Dave Airlie
@ 2010-03-01 17:06 ` Alex Deucher
2010-03-01 17:15 ` Randy Dunlap
0 siblings, 1 reply; 4+ messages in thread
From: Alex Deucher @ 2010-03-01 17:06 UTC (permalink / raw)
To: Dave Airlie; +Cc: Randy Dunlap, lkml, David Airlie
On Mon, Mar 1, 2010 at 1:01 AM, Dave Airlie <airlied@gmail.com> wrote:
> On Thu, Feb 25, 2010 at 8:27 AM, Randy Dunlap <randy.dunlap@oracle.com> wrote:
>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>
>> Fix radeon/atombios.h sparse warning (24 times):
>>
>> drivers/gpu/drm/radeon/atombios.h:4091:63: error: Bad character constant
>
> We get this file from AMD pretty much as-is and I hate deviating it as it
> causes merge issues. Alex any change you can get this fixed upstream?
>
I can try.
Alex
> Dave.
>
>>
>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>> Cc: David Airlie <airlied@linux.ie>
>> ---
>> drivers/gpu/drm/radeon/atombios.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- linux-2.6.33-rc8.orig/drivers/gpu/drm/radeon/atombios.h
>> +++ linux-2.6.33-rc8/drivers/gpu/drm/radeon/atombios.h
>> @@ -4088,7 +4088,7 @@ typedef struct _SW_I2C_IO_DATA_PARAMETER
>> #define SW_I2C_CNTL_WRITE1BIT 6
>>
>> /* ==============================VESA definition Portion=============================== */
>> -#define VESA_OEM_PRODUCT_REV '01.00'
>> +#define VESA_OEM_PRODUCT_REV "01.00"
>> #define VESA_MODE_ATTRIBUTE_MODE_SUPPORT 0xBB /* refer to VBE spec p.32, no TTY support */
>> #define VESA_MODE_WIN_ATTRIBUTE 7
>> #define VESA_WIN_SIZE 64
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at http://www.tux.org/lkml/
>>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm: fix char constant (sparse warning)
2010-03-01 17:06 ` Alex Deucher
@ 2010-03-01 17:15 ` Randy Dunlap
0 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2010-03-01 17:15 UTC (permalink / raw)
To: Alex Deucher; +Cc: Dave Airlie, Randy Dunlap, lkml, David Airlie
On 03/01/10 09:06, Alex Deucher wrote:
> On Mon, Mar 1, 2010 at 1:01 AM, Dave Airlie <airlied@gmail.com> wrote:
>> On Thu, Feb 25, 2010 at 8:27 AM, Randy Dunlap <randy.dunlap@oracle.com> wrote:
>>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>>
>>> Fix radeon/atombios.h sparse warning (24 times):
>>>
>>> drivers/gpu/drm/radeon/atombios.h:4091:63: error: Bad character constant
>>
>> We get this file from AMD pretty much as-is and I hate deviating it as it
>> causes merge issues. Alex any change you can get this fixed upstream?
Ah, thanks for that info.
>>
>
> I can try.
>
> Alex
OK, thanks.
>> Dave.
>>
>>>
>>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>>> Cc: David Airlie <airlied@linux.ie>
>>> ---
>>> drivers/gpu/drm/radeon/atombios.h | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> --- linux-2.6.33-rc8.orig/drivers/gpu/drm/radeon/atombios.h
>>> +++ linux-2.6.33-rc8/drivers/gpu/drm/radeon/atombios.h
>>> @@ -4088,7 +4088,7 @@ typedef struct _SW_I2C_IO_DATA_PARAMETER
>>> #define SW_I2C_CNTL_WRITE1BIT 6
>>>
>>> /* ==============================VESA definition Portion=============================== */
>>> -#define VESA_OEM_PRODUCT_REV '01.00'
>>> +#define VESA_OEM_PRODUCT_REV "01.00"
>>> #define VESA_MODE_ATTRIBUTE_MODE_SUPPORT 0xBB /* refer to VBE spec p.32, no TTY support */
>>> #define VESA_MODE_WIN_ATTRIBUTE 7
>>> #define VESA_WIN_SIZE 64
>>> --
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-03-01 17:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-24 22:27 [PATCH] drm: fix char constant (sparse warning) Randy Dunlap
2010-03-01 6:01 ` Dave Airlie
2010-03-01 17:06 ` Alex Deucher
2010-03-01 17:15 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox