From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Anton Vorontsov <avorontsov@ru.mvista.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
Sergei Shtylyov <sshtylyov@mvista.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 09/11] ahci: Move generic code into libahci
Date: Wed, 03 Mar 2010 20:33:47 +0300 [thread overview]
Message-ID: <4B8E9D7B.6040709@ru.mvista.com> (raw)
In-Reply-To: <20100303171747.GI12362@oksana.dev.rtsoft.ru>
Hello.
Anton Vorontsov wrote:
> This patch should contain no functional changes, just moves code
> around.
>
> Currently libahci.c and ahci.c are built into a single module,
> so there is no need for EXPORT_SYMBOL_GPL()s, yet. Exports will be
> added in a subsequent patch.
>
This is not true anymore, so the exports are probably needed.
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> ---
> drivers/ata/Makefile | 2 +-
> drivers/ata/ahci.c | 2271 +------------------------------------------------
> drivers/ata/libahci.c | 2059 ++++++++++++++++++++++++++++++++++++++++++++
> drivers/ata/libahci.h | 330 +++++++
> 4 files changed, 2391 insertions(+), 2271 deletions(-)
> create mode 100644 drivers/ata/libahci.c
> create mode 100644 drivers/ata/libahci.h
>
> diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile
> index b7d4923..75e3abd 100644
> --- a/drivers/ata/Makefile
> +++ b/drivers/ata/Makefile
> @@ -1,7 +1,7 @@
>
> obj-$(CONFIG_ATA) += libata.o
>
> -obj-$(CONFIG_SATA_AHCI) += ahci.o
> +obj-$(CONFIG_SATA_AHCI) += libahci.o ahci.o
>
This means 2 different modules: libahci.ko and ahci.ko.
MBR, Sergei
next prev parent reply other threads:[~2010-03-03 17:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-03 17:17 [PATCH 0/11] ahci: Add support for non-PCI devices Anton Vorontsov
2010-03-03 17:17 ` [PATCH 01/11] ahci: Get rid of host->iomap usage Anton Vorontsov
2010-03-03 18:45 ` Jeff Garzik
2010-03-03 18:49 ` Jeff Garzik
2010-03-03 17:17 ` [PATCH 02/11] ahci: Factor out PCI specifics from ahci_save_initial_config() Anton Vorontsov
2010-03-03 17:17 ` [PATCH 03/11] ahci: Get rid of pci_dev argument in ahci_save_initial_config() Anton Vorontsov
2010-03-03 17:17 ` [PATCH 04/11] ahci: Factor out PCI specifics from ahci_reset_controller() Anton Vorontsov
2010-03-03 17:17 ` [PATCH 05/11] ahci: Get rid of pci_dev argument in ahci_port_init() Anton Vorontsov
2010-03-03 17:17 ` [PATCH 06/11] ahci: Factor out PCI specifics from ahci_init_controller() Anton Vorontsov
2010-03-03 17:17 ` [PATCH 07/11] ahci: Factor out PCI specifics from ahci_print_info() Anton Vorontsov
2010-03-03 17:17 ` [PATCH 08/11] ahci: Introduce ahci_set_em_messages() Anton Vorontsov
2010-03-03 20:52 ` Jeff Garzik
2010-03-03 17:17 ` [PATCH 09/11] ahci: Move generic code into libahci Anton Vorontsov
2010-03-03 17:33 ` Sergei Shtylyov [this message]
2010-03-03 17:45 ` Anton Vorontsov
2010-03-03 18:43 ` Jeff Garzik
2010-03-03 21:58 ` Mark Lord
2010-03-03 17:17 ` [PATCH 10/11] ahci: Export generic AHCI symbols, turn libahci into a separate module Anton Vorontsov
2010-03-03 17:53 ` Sergei Shtylyov
2010-03-03 18:08 ` Anton Vorontsov
2010-03-03 18:14 ` Anton Vorontsov
2010-03-03 18:34 ` Jeff Garzik
2010-03-03 18:42 ` Anton Vorontsov
2010-03-03 17:17 ` [PATCH 11/11] ahci: Add platform driver Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B8E9D7B.6040709@ru.mvista.com \
--to=sshtylyov@mvista.com \
--cc=avorontsov@ru.mvista.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox